Re: [Pnet-developers] SSL/TLS support in pnetlib

[Rhys Weatherley]

On Saturday 31 May 2003 06:06 pm, Gopal V wrote:

> I have just committed the SSL support into HttpWebRequest ... and tested
> it by downloading a page from https://secure.symonds.net/ which means we're
> cool !.

Fantastic!

> I hope I implemented it right ... ie a Session is constructed globally ,
> which I hope is not wrong ?. This session is destroyed only when we
> close down the VM because the object containing the Session is held
> in a static field. Should I generate a new session per hostname ?.

A new session every time.  The session provider can be stored globally, but it 
isn't really necessary to do that.  The current code is OK, but I suggest 
removing the static for the provider because there's no need.  Call 
"GetProvider()" and then "CreateClientSession()" in the "SecureConnection" 
constructor.  If it ever makes sense to cache providers, we'll do it in the 
"DotGNU.SSL" assembly instead.

> Also I do think we should put some sort of #if #endif around it to
> trim it down ... what should be the condition ?

"CONFIG_SSL" or "CONFIG_TLS" would be my guess.  Toss a coin - either is fine 
by me.

Cheers,

Rhys.