[Elisp-code-dired] Dired 7.13 bug: don't quote + in filenames

[Adrian Aichner]

Hi!

I don't think + should be quoted in file names.

With this patch I can run
! runs the command dired-do-shell-command
on filenames like
20070819T101640+0200.wav

I am trying to use timestamps including timezone offset as names for
files that are best qualified by time of creation (e.g. pictures,
audio recordings, etc.).

With the quoting I get:

---------------------------
Sound Recorder
---------------------------
Cannot open 'c:\Documents and Settings\aichnerad\My Documents\Xda_orbit My 
Documents\20070819T101640\+0200.wav'.
---------------------------
OK   
---------------------------

Adrian

How about this:

diff -u c:\Program Files\XEmacs\xemacs-packages\lisp\dired\dired-shell.el.~1~ 
c:\Program Files\XEmacs\xemacs-packages\lisp\dired\dired-shell.el
--- c:\Program Files\XEmacs\xemacs-packages\lisp\dired\dired-shell.el.~1~       
2007-08-21 01:11:14.703000000 +0200
+++ c:\Program Files\XEmacs\xemacs-packages\lisp\dired\dired-shell.el   
2007-08-21 01:11:14.718625000 +0200
@@ -197,7 +197,7 @@
   ;; Quote everything except POSIX filename characters.
   ;; This should be safe enough even for really weird shells.
   (let ((result "") (start 0) end)
-    (while (string-match "[^---0-9a-zA-Z_./]" filename start)
+    (while (string-match "[^---0-9a-zA-Z_.+/]" filename start)
       (setq end (match-beginning 0)
            result (concat result (substring filename start end)
                           "\\" (substring filename end (1+ end)))


Emacs  : XEmacs 21.5  (beta28) "fuki" (+CVS-20070818) [Lucid] (i586-pc-win32, 
Mule) of Sun Aug 19 2007 on TANG
Package: Dired

current state:
==============
(setq
 dired-version "7.13"
 dired-auto-shell-command-alist '(("\\.\\(dll\\|ocx\\)$" "regsvr32 \"*\"")
                                  ("\\.xl[st]$" "excel")
                                  ("\\.do[ct]$" "winword")
                                  ("\\.ppt$" "powerpnt \"*\"")
                                  ("."
                                   (if
                                    (file-directory-p
                                     (file-name-as-directory (car files)))
                                    "explorer" "notepad")
                                   )
                                  ("."
                                   (apa-dired-auto-shell-command-clearcase))
                                  )
 dired-backup-if-overwrite nil
 dired-chown-program "/etc/chown"
 dired-cleanup-alist '(("tex" ".toc" ".log" ".aux" ".dvi")
                       ("latex" ".toc" ".log" ".aux" ".idx" ".lof" ".lot"
                        ".glo" ".dvi")
                       ("bibtex" ".blg" ".bbl")
                       ("texinfo" ".cp" ".cps" ".fn" ".fns" ".ky" ".kys" ".pg"
                        ".pgs" ".tp" ".tps" ".vr" ".vrs")
                       ("patch" ".rej" ".orig") ("backups" "~")
                       ("completion-ignored-extensions" ".svn/" "CM/" "CVS/"
                        ".o" ".obj" ".elc" "~" ".bin" ".lbin" ".dvi" ".class")
                       )
 dired-compression-method 'gzip
 dired-compression-method-alist '((gzip ".gz" ("gzip" "-9") ("gzip" "-d") "-f")
                                  (compress ".Z" ("compress" "-f")
                                   ("compress" "-d") "-f")
                                  (pack ".z" ("pack" "-f") ("unpack")))
 dired-copy-preserve-time t
 dired-dwim-target nil
 dired-failed-marker-shell ?!
 dired-filename-re-ext "\\..+\\'"
 dired-find-subdir nil
 dired-gnutar-program "tar"
 dired-keep-marker-compress t
 dired-keep-marker-copy ?C
 dired-keep-marker-hardlink ?H
 dired-keep-marker-kill ?K
 dired-keep-marker-rename t
 dired-keep-marker-symlink ?S
 dired-keep-marker-uucode ?U
 dired-kept-versions 2
 dired-listing-switches "-al"
 dired-local-variables-file ".dired"
 dired-ls-F-marks-symlinks nil
 dired-ls-program "ls"
 dired-mail-reader 'vm
 dired-mode-line-modified "-%s%s%s-"
 dired-no-confirm nil
 dired-omit-extensions '(".class" ".lbin" ".bin" ".elc" ".obj" ".o" "CVS/"
                         "CM/" ".svn/" "~" ".orig" ".rej" ".vrs" ".vr" ".tps"
                         ".tp" ".pgs" ".pg" ".kys" ".ky" ".fns" ".fn" ".cps"
                         ".cp" ".bbl" ".blg" ".glo" ".lot" ".lof" ".idx"
                         ".dvi" ".aux" ".log" ".toc")
 dired-omit-files nil
 dired-omit-regexps '("\\`#" "\\`\\.")
 dired-refresh-automatically t
 dired-shell-failure-marker ?!
 dired-show-ls-switches nil
 dired-trivial-filenames "\\`\\.\\.?\\'\\|\\`#"
 dired-unshar-program nil
 dired-use-file-transformers t
 dired-verify-modtimes t
 reporter-version "Your version of reporter is obsolete.  Please upgrade."
 )
-- 
Adrian Aichner
 mailto:address@hidden
 http://www.xemacs.org/