--- Begin Message ---
Subject: |
Color escape codes in the output of vc-git-print-log |
Date: |
Mon, 14 Dec 2009 17:12:24 +0100 |
Package: emacs,vc
Tags: patch
Version: 23.1.90
Severity: minor
Depending of your setting of color.diff, color is used for log output,
and vc-print-log shows garbage (OK, escape codes for color):
^[[33mcommit 43a3bf88e5e495ad048b3a6d3cf852e1e7a02f1c^[[m
Author: xxx <address@hidden>
Date: 2009-12-14 17:11:35 +0200
blah blah blah
As color in *vc-change-log* buffers is an issue for font-locking, and
not for git log, the command should be called with --no-color.
OK to the following patch?
Juanma
2009-12-14 Juanma Barranquero <address@hidden>
* vc-git.el (vc-git-print-log): Pass --no-color to `git log'.
=== modified file 'lisp/vc-git.el'
--- lisp/vc-git.el 2009-12-08 15:56:57 +0000
+++ lisp/vc-git.el 2009-12-14 16:08:54 +0000
@@ -555,7 +555,7 @@
(apply 'vc-git-command buffer
'async files
(append
- '("log")
+ '("log" "--no-color")
(when shortlog
'("--graph" "--decorate"
"--date=short" "--pretty=format:%d%h %ad %s"
"--abbrev-commit"))
--- End Message ---
--- Begin Message ---
Subject: |
Re: bug#5211: Color escape codes in the output of vc-git-print-log |
Date: |
Mon, 28 Dec 2009 03:47:52 +0100 |
On Wed, Dec 16, 2009 at 00:57, Juanma Barranquero <address@hidden> wrote:
> So --no-color was first included in a release of 2006-08-13. Is that
> old enough? (git 1.0.0 is from 2005-12-21, barely eight months
> earlier, so 1.4.2 is quite old indeed).
I've committed this change (with the acquiescence of Chong Yidong).
Juanma
--- End Message ---