--- Begin Message ---
|
Subject: |
[PATCH] make dist target for Windows |
|
Date: |
Sat, 10 Jul 2010 08:00:25 -0600 |
|
User-agent: |
Mozilla/5.0 (Windows; U; Windows NT 6.1; en-US; rv:1.9.2.4) Gecko/20100608 Thunderbird/3.1 |
Glenn Morris wrote:
> Also, I keep saying this, but I strongly advise people to post patches
> like this to the bug list, since then they are much less likely to get
> forgotten / overlooked. I used to forward things there, but have given
> up. If you post things here, you basically rely on people keeping
> things in their inbox until dealt with.
Following Glenn's advice I repost my patch to this list.
Initial discussion of this patch:
http://lists.gnu.org/archive/html/emacs-devel/2010-03/msg01461.html
Thanks,
Christoph
-------- Original Message --------
Subject: Re: make dist target for Windows
Date: Sat, 03 Jul 2010 11:08:03 -0600
From: Christoph <address@hidden>
To: Eli Zaretskii <address@hidden>
CC: Christoph <address@hidden>, address@hidden
On 4/8/2010 11:51 AM, Eli Zaretskii wrote:
Well, do you have assignment to FSF on record? I cannot see it. If
you don't, please talk to Stefan and Yidong to start the paperwork.
Once that is done, someone will install this for you.
I finally got my confirmation email from the FSF, that my paperwork has
been processed.
Find attached the patch to implement the make dist target for Windows.
Thanks,
Christoph
makedistw32v6.txt
Description: Text document
--- End Message ---
--- Begin Message ---
|
Subject: |
Re: bug#6602: [PATCH] make dist target for Windows |
|
Date: |
Sat, 24 Jul 2010 15:28:41 +0200 |
On Sat, Jul 24, 2010 at 05:18, Christoph <address@hidden> wrote:
> Find attached the new patch for the `make dist' target.
>
> I added a Changelog and NEWS entry and removed README.W32 and makedist.bat
> files from the nt/ directory.
OK, thaks a lot.
A few comments (nitpicks, mostly):
- You've added the ChangeLog entry to the root directory's ChangeLog,
instead of nt/ChangeLog. Also, it lacks an entry in admin/ChangeLog
about the changes in that directory (you've documented most of them in
the other ChangeLog, though). In some cases, as when moving files, it
is customary to put a "Moved to X/" entry in the old directory's
ChangeLog, and ad "Moved from Y/" in the new's.
- Changes to documentation files, like etc/NEWS and nt/INSTALL, must
also be documented in ChangeLog entries.
- If you're going to move a file, like README.W32, instead of
cd admin/nt
copy README.W32 ../../nt
del README.W32
or
move admin/nt/README.W32 nt/
please do
bzr mv admin/nt/README.W32 nt/
so Bazaar knows that it is the same file.
- It's best if you do these changes in a branch, and then submit a
bundle. For example, applying your patch creates a file
nt/zipdist.bat, but it has to be "bzr add"ed manually.
- Try not to introduce trailing whitespace in files you modify. Not
earth-shaking, but ugly if you have `show-trailing-whitespace' set to
t (which I recommend).
That said, I'm committing your change right now. Great work. Thanks!
Juanma
--- End Message ---