[debbugs-tracker] bug#9480: closed (24.0.50; (vc-git) address@hidden - requires shell quoting?)

[GNU bug Tracking System]

Your message dated Wed, 14 Sep 2011 07:57:40 -0400
with message-id <address@hidden>
and subject line Re: bug#9480: 24.0.50; (vc-git) address@hidden - requires 
shell quoting?
has caused the debbugs.gnu.org bug report #9480,
regarding 24.0.50; (vc-git) address@hidden - requires shell quoting?
to be marked as done.

(If you believe you have received this mail in error, please contact
address@hidden)


-- 
9480: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9480
GNU Bug Tracking System
Contact address@hidden with problems

--- Begin Message --- Subject: 24.0.50; (vc-git) address@hidden - requires shell quoting? Date: Mon, 12 Sep 2011 12:39:43 +0530

While in a *vc-dir* buffer (backed by git) and trying to show or apply a
stash fails.

I am attaching "works for me" patch that shell-quotes address@hidden
argument. With this "patch", the stash commands work as expected.

My shell-file-name is set to "bash" (cygwin version). My Emacs is

In GNU Emacs 24.0.50.1 (i386-mingw-nt5.1.2600)
 of 2011-09-06 on 3249CTO
Windowing system distributor `Microsoft Corp.', version 5.1.2600
configured using `configure --with-gcc (4.5) --no-opt'

Additional Info:

,----
| VC backend : Git
| Working dir: ~/src/org-mode/
| Branch     : master
| Remote     : address@hidden:org-mode.git
| Stash      :
|              {0}: On master: custom tables  <-----
`----

FWIW, the stash line has following keymap:

,----
| (keymap
|  (83 . vc-git-stash-snapshot)
|  (80 . vc-git-stash-pop-at-point)
|  (65 . vc-git-stash-apply-at-point)
|  (13 . vc-git-stash-show-at-point)
|  (61 . vc-git-stash-show-at-point)
|  (11 . vc-git-stash-delete-at-point)
|  (down-mouse-3 . vc-git-stash-menu)
|  (mouse-2 . ignore))
`----

vc-git.el.patch
Description: Text Data

--- End Message ---

> --- Begin Message ---
>
>
>
> Subject: 
>
> Re: bug#9480: 24.0.50; (vc-git) address@hidden - requires shell quoting?
>
>
>
>
> Date: 
>
> Wed, 14 Sep 2011 07:57:40 -0400
>
>
>
>
> > From: Jambunathan K <address@hidden>
> > Cc:  Stefan Monnier <address@hidden>,  address@hidden
> > Date: Wed, 14 Sep 2011 16:28:27 +0530
> > 
> > Glenn Morris <address@hidden> writes:
> > 
> > > Eli Zaretskii wrote:
> > >
> > >> This should generally work fine, except that IMO globbing in this case
> > >> is simply buggy: the braces are removed although a real shell would
> > >> expand "{0}" into itself.
> > >
> > > I agree.
> > 
> > Glenn
> > Thanks for the reference note. I will file a bug report with Cygwin very
> > soon.
> > 
> > Eli
> > Feel free to close this bug.
>
> Done.
>
>
> --- End Message ---