emacs-bug-tracker
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[debbugs-tracker] bug#8168: closed (macros directory not created automat


From: GNU bug Tracking System
Subject: [debbugs-tracker] bug#8168: closed (macros directory not created automatically)
Date: Sat, 17 Mar 2012 09:18:02 +0000

Your message dated Sat, 17 Mar 2012 09:46:30 +0100
with message-id <address@hidden>
and subject line Re: bug#10816: [PATCH] aclocal: create local directory where 
to install m4 files
has caused the debbugs.gnu.org bug report #10816,
regarding macros directory not created automatically
to be marked as done.

(If you believe you have received this mail in error, please contact
address@hidden)


-- 
10816: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=10816
GNU Bug Tracking System
Contact address@hidden with problems
--- Begin Message --- Subject: Re: macros directory not created automatically Date: Thu, 3 Mar 2011 21:36:51 +0100 User-agent: KMail/1.13.3 (Linux/2.6.30-2-686; KDE/4.4.4; i686; ; )
[adding bug-automake]

On Thursday 03 March 2011, Javier Jardón wrote:
> Hi,
>
Hi Javier, and thanks for the report.

> I'm using
> 
> ACLOCAL_AMFLAGS = -I m4 ${ACLOCAL_FLAGS}
> 
> in my main Makefile.am, but I have to add the m4 directory to the git
> tree, or create it in my autogen script (and this doesnt work if I do
> not use a autogen file and only autoreconf instead)
> 
> Shouldnt be automake smart enough to create that directory automatically?
>
Probably yes -- but IMHO it should then also be smart enough to create
the directory *only* when it makes sense, i.e. only when the `--install'
flag is used too.

Also, it might be useful if aclocal would not complain (or at least would
not error out) in case it is passed a non-existent or unreadable directory
through the `-I' option.  This "laxer" behaviour is implemented in many
other gnu tools already (e.g., make, m4. gcc).

I might take a look at this issues in the next(ish) days.

Thanks,
  Stefano



--- End Message ---
--- Begin Message --- Subject: Re: bug#10816: [PATCH] aclocal: create local directory where to install m4 files Date: Sat, 17 Mar 2012 09:46:30 +0100
On 03/15/2012 08:57 PM, Stefano Lattarini wrote:
> Fixes automake bug#8168 and bug#10816.
> 
> A call like "aclocal -I m4 --install" used to fail if the 'm4'
> directory wasn't pre-existing.  This could be particularly
> annoying when running in a checked-out version from a VCS like
> git, which doesn't allow empty directories to be tracked.
> 
> * aclocal.in (File::Path): New import.
> (scan_m4_dirs): Don't die if the first directory of type FT_USER
> doesn't exist and the '--install' option was given; that directory
> will be created later in ...
> (install_file): ... here.  Change signature: now it takes as second
> argument the destination directory rather than the destination file.
> Crate the destination directory if it doesn't already exist.  In
> verbose mode, tell what is being copied where.
> (write_aclocal): Update.
> * NEWS, THANKS: Update.
> * tests/aclocal-install-fail.test: New test.
> * tests/aclocal-install-mkdir.test: Likewise.
> * tests/aclocal-no-install-no-mkdir.test: Likewise.
> * tests/aclocal-verbose-install.test: Likewise.
> * tests/list-of-tests.mk: Add them.
> 
> Signed-off-by: Stefano Lattarini <address@hidden>
> ---
> 
>  I will push this in a couple of days if there is no objection.
>  Thanks to David and Javier, and sorry for the awful delay.
> 
No objection seen so far, so I've pushed this patch (with minor
adjustments, see commit a75a1a52).  I'm also closing the relevant
bug reports.

Regards,
  Stefano


--- End Message ---

reply via email to

[Prev in Thread] Current Thread [Next in Thread]