[debbugs-tracker] bug#12002: closed (24.1.50; ERC nick change trouble)

[GNU bug Tracking System]

Your message dated Sat, 06 Oct 2012 21:29:22 -0400
with message-id <address@hidden>
and subject line Re: bug#12002: 24.1.50; ERC nick change trouble
has caused the debbugs.gnu.org bug report #12002,
regarding 24.1.50; ERC nick change trouble
to be marked as done.

(If you believe you have received this mail in error, please contact
address@hidden)


-- 
12002: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=12002
GNU Bug Tracking System
Contact address@hidden with problems
> --- Begin Message ---
>
>
>
> Subject: 
>
> 24.1.50; ERC nick change trouble
>
>
>
>
> Date: 
>
> Sat, 21 Jul 2012 00:56:25 +0200
>
>
>
>
> User-agent: 
>
> Gnus/5.13 (Gnus v5.13) Emacs/24.1.50 (gnu/linux)
>
>
>
>
> Hi,
>
> There's a bug in ERC nick change handling. Imagine you have a query with
> john, who has a timeout. He then comes back as john-, and queries
> you. Then, when his old timeout goes away, he changes nick back to
> john. The ERC response handler then tries to change the john- query
> buffer name to john, which clashes with the old buffer. Since there was
> an error in the execution flow, everything is messed up.
>
> Here's a patch that doesn't try to change the name back when a buffer of
> the same name exists. It still notifies the old query buffer of the name
> change though. I haven't tested it but it should be fine. (I think ...)
>
> I'm not holding my breath on this, because of the lack of activity of
> ERC maintainers. Still, at least the patch is out there.
>
> diff --git a/lisp/erc/erc-backend.el b/lisp/erc/erc-backend.el
> index cce24e6..115c31f 100644
> --- a/lisp/erc/erc-backend.el
> +++ b/lisp/erc/erc-backend.el
> @@ -1313,10 +1313,11 @@ add things to `%s' instead."
>        (erc-buffer-filter
>         (lambda ()
>           (when (equal (erc-default-target) nick)
> -           (setq erc-default-recipients
> -                 (cons nn (cdr erc-default-recipients)))
> -           (rename-buffer nn)
> -           (erc-update-mode-line)
> +           (unless (get-buffer nn)
> +             (setq erc-default-recipients
> +                   (cons nn (cdr erc-default-recipients)))
> +             (rename-buffer nn)
> +             (erc-update-mode-line))
>             (add-to-list 'bufs (current-buffer)))))
>        (erc-update-user-nick nick nn host nil nil login)
>        (cond
>
>
>
> --- End Message ---
> --- Begin Message ---
>
>
>
> Subject: 
>
> Re: bug#12002: 24.1.50; ERC nick change trouble
>
>
>
>
> Date: 
>
> Sat, 06 Oct 2012 21:29:22 -0400
>
>
>
>
> User-agent: 
>
> Gnus (www.gnus.org), GNU Emacs (www.gnu.org/software/emacs/)
>
>
>
>
> Version: 24.3
>
> Thanks. I installed a simpler change (below). Please let me know if it
> is not ok, since I don't use erc.
>
> *** lisp/erc/erc-backend.el     2012-10-06 01:04:53 +0000
> --- lisp/erc/erc-backend.el     2012-10-07 01:25:39 +0000
> ***************
> *** 1316,1322 ****
>            (when (equal (erc-default-target) nick)
>              (setq erc-default-recipients
>                    (cons nn (cdr erc-default-recipients)))
> !            (rename-buffer nn)
>              (erc-update-mode-line)
>              (add-to-list 'bufs (current-buffer)))))
>         (erc-update-user-nick nick nn host nil nil login)
> --- 1316,1322 ----
>            (when (equal (erc-default-target) nick)
>              (setq erc-default-recipients
>                    (cons nn (cdr erc-default-recipients)))
> !            (rename-buffer nn t)         ; bug#12002
>              (erc-update-mode-line)
>              (add-to-list 'bufs (current-buffer)))))
>         (erc-update-user-nick nick nn host nil nil login)
>
>
>
> --- End Message ---