[debbugs-tracker] bug#12221: closed (24.2; shell completion can not handle multiple candidates)

[GNU bug Tracking System]

Your message dated Fri, 19 Oct 2012 17:11:13 -0400
with message-id <address@hidden>
and subject line 24.2; shell completion can not handle multiple candidates
has caused the debbugs.gnu.org bug report #12221,
regarding 24.2; shell completion can not handle multiple candidates
to be marked as done.

(If you believe you have received this mail in error, please contact
address@hidden)


-- 
12221: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=12221
GNU Bug Tracking System
Contact address@hidden with problems
> --- Begin Message ---
>
>
>
> Subject: 
>
> 24.2; shell completion can not handle multiple candidates
>
>
>
>
> Date: 
>
> Sat, 18 Aug 2012 10:31:04 +0800
>
>
>
>
> 1. Emacs -q
> 2. (setq completion-cycle-threshold 3)
> 3. M-x shell
> 4. fu <tab>
>
> In OSX, the last step completes to `fuser' ignoring `funzip'. The
> completion cannot cycle because of the extra ' ' inserted which
> demonstrates one of the failures of completion-at-point as reported in
> http://debbugs.gnu.org/11906.
>
> Leo
>
>
>
> --- End Message ---
> --- Begin Message ---
>
>
>
> Subject: 
>
> 24.2; shell completion can not handle multiple candidates
>
>
>
>
> Date: 
>
> Fri, 19 Oct 2012 17:11:13 -0400
>
>
>
>
> User-agent: 
>
> Gnus/5.13 (Gnus v5.13) Emacs/24.1.50 (gnu/linux)
>
>
>
>
> I've installed the patch below which I believe fixes the bug, finally.
>
>
>         Stefan
>
>
> === modified file 'lisp/ChangeLog'
> --- lisp/ChangeLog      2012-10-19 09:28:50 +0000
> +++ lisp/ChangeLog      2012-10-19 18:58:27 +0000
> @@ -1,3 +1,8 @@
> +2012-10-19  Stefan Monnier  <address@hidden>
> +
> +       * minibuffer.el (minibuffer-force-complete): Make the next completion 
> use
> +       the same completion-field (address@hidden).
> +
>  2012-10-19  Martin Rudalics  <address@hidden>
>  
>         * emacs-lisp/debug.el (debug): Record height of debugger window
>
> === modified file 'lisp/minibuffer.el'
> --- lisp/minibuffer.el  2012-10-18 03:30:04 +0000
> +++ lisp/minibuffer.el  2012-10-19 18:40:12 +0000
> @@ -1134,7 +1134,23 @@
>        ;; through the previous possible completions.
>        (let ((last (last all)))
>          (setcdr last (cons (car all) (cdr last)))
> -        (completion--cache-all-sorted-completions (cdr all)))))))
> +        (completion--cache-all-sorted-completions (cdr all)))
> +      ;; Make sure repeated uses cycle, even though completion--done might
> +      ;; have added a space or something that moved us outside of the field.
> +      ;; (bug#12221).
> +      (let* ((table minibuffer-completion-table)
> +             (pred minibuffer-completion-predicate)
> +             (extra-prop completion-extra-properties)
> +             (cmd
> +              (lambda () "Cycle through the possible completions."
> +                (interactive)
> +                (let ((completion-extra-properties extra-prop))
> +                  (completion-in-region start (point) table pred)))))
> +        (set-temporary-overlay-map
> +         (let ((map (make-sparse-keymap)))
> +           (define-key map [remap completion-at-point] cmd)
> +           (define-key map (vector last-command-event) cmd)
> +           map)))))))
>  
>  (defvar minibuffer-confirm-exit-commands
>    '(completion-at-point minibuffer-complete
> @@ -1557,7 +1573,6 @@
>    (let* ((exit-fun (plist-get completion-extra-properties :exit-function))
>           (pre-msg (and exit-fun (current-message))))
>      (cl-assert (memq finished '(exact sole finished unknown)))
> -    ;; FIXME: exit-fun should receive `finished' as a parameter.
>      (when exit-fun
>        (when (eq finished 'unknown)
>          (setq finished
>
>
> --- End Message ---