--- Begin Message ---
|
Subject: |
Assume at least POSIX.1-1988 for fcntl.h |
|
Date: |
Tue, 13 Nov 2012 23:37:58 -0800 |
|
User-agent: |
Mozilla/5.0 (X11; Linux i686; rv:16.0) Gecko/20121028 Thunderbird/16.0.2 |
Tags: patch
On POSIXish hosts it's long been safe to assume at least
POSIX.1-1988, as the pre-POSIX platforms died out long ago.
Attached is a patch to simplify Emacs to assume this
for <fcntl.h>. I haven't tested this on Windows but have
tried to make the Windows port work by renaming its O_NDELAY
flag to O_NONBLOCK, as POSIX standardized the spelling of this
flag to be O_NONBLOCK. I'll CC: this patch to Eli to give
him a heads-up. This patch is relative to trunk bzr 110892.
fcntl.txt
Description: Text document
--- End Message ---
--- Begin Message ---
|
Subject: |
Re: Assume at least POSIX.1-1988 for fcntl.h |
|
Date: |
Sat, 17 Nov 2012 14:17:14 -0800 |
|
User-agent: |
Mozilla/5.0 (X11; Linux i686; rv:16.0) Gecko/20121028 Thunderbird/16.0.2 |
On 11/16/2012 01:49 AM, Eli Zaretskii wrote:
> I wonder how it compiled for you;
> presumably some other header on your platform includes fcntl.h
> internally
It's systty.h, which includes fcntl.h everywhere.
But it doesn't hurt to include it again, so I did that.
I took the other suggestions you made as well, except
that I moved the replacement definitions of O_RDWR and
O_NOCTTY into nt/inc/unistd.h rather than to some other
spot in term.c. It's cleaner to define system macros
in our implementation of the system rather than in the
application. In the longer run we may want to move those
macros to a new file that replaces fcntl.h, but that's
for another day.
I installed this as trunk bzr 110931 and am marking it as
done.
--- End Message ---