emacs-bug-tracker
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[debbugs-tracker] bug#3210: closed (face customization fails after set-f


From: GNU bug Tracking System
Subject: [debbugs-tracker] bug#3210: closed (face customization fails after set-face-attribute)
Date: Sun, 25 Nov 2012 05:07:02 +0000

Your message dated Sun, 25 Nov 2012 13:04:32 +0800
with message-id <address@hidden>
and subject line Re: bug#3408: bug#3210: face customization fails after 
set-face-attribute
has caused the debbugs.gnu.org bug report #3408,
regarding face customization fails after set-face-attribute
to be marked as done.

(If you believe you have received this mail in error, please contact
address@hidden)


-- 
3408: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=3408
GNU Bug Tracking System
Contact address@hidden with problems
--- Begin Message --- Subject: face customization fails after set-face-attribute Date: Mon, 4 May 2009 16:04:35 -0400
Emacs -Q

(set-face-attribute 'default nil
                    :height 130
                    :family "Lucida Grande")
;; modifies default face

(customize-face 'default)
;; switch back manually to Monaco and "set for current session"

(make-frame-command)  ;; C-x 5 2
;; the new frame is shown in Lucida.  Why?


Upon inspection of some code, it appears unclear why `face-spec-set' iterates over all frame faces and sets the new spec there, but doesn't set the right property to set the face for future frames in case for- defface is t.




--- End Message ---
--- Begin Message --- Subject: Re: bug#3408: bug#3210: face customization fails after set-face-attribute Date: Sun, 25 Nov 2012 13:04:32 +0800 User-agent: Gnus/5.13 (Gnus v5.13) Emacs/24.2.90 (gnu/linux)
"Drew Adams" <address@hidden> writes:

> Bug #3408 is a _regression_, and it has not been fixed.
> A regression is certainly NOT `notabug'.

I disagree that this is a bug.  I have now taken another look at the
code, and my earlier conclusion stands.  Modifications to internal Lisp
faces (via set-face-attribute) take precedence over the effect of face
specs, so the behavior is working as intended and as documented
(including in the docstring of set-face-attribute).

The trunk now contains a change to face-spec-set which allows it to be
more easily called from Lisp code to override defface specs.  If you
want to modify faces from Lisp, use that rather than set-face-attribute.

Don't re-open this bug based on uninformed opinion.  Thanks.


--- End Message ---

reply via email to

[Prev in Thread] Current Thread [Next in Thread]