[debbugs-tracker] bug#13448: closed (Cannot build Emacs 24.2.92)

[GNU bug Tracking System]

Your message dated Tue, 15 Jan 2013 13:30:21 -0800
with message-id <address@hidden>
and subject line Re: bug#13448: Cannot build Emacs 24.2.92
has caused the debbugs.gnu.org bug report #13448,
regarding Cannot build Emacs 24.2.92
to be marked as done.

(If you believe you have received this mail in error, please contact
address@hidden)


-- 
13448: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=13448
GNU Bug Tracking System
Contact address@hidden with problems

--- Begin Message --- Subject: Cannot build Emacs 24.2.92 Date: Tue, 15 Jan 2013 17:59:31 +0800

I configured Emacs pretest 24.2.92 using:

    ./configure --with-wide-int --enable-link-time-optimization 
--enable-gcc-warnings

Then I:

    make

After that:

See attachment.

I'm using Ubuntu 12.10 to build Emacs 24.2.92.
-- 
Best regards, Xue Fuqiao.
http://www.emacswiki.org/emacs/XueFuqiao

make.txt
Description: Text document

--- End Message ---

> --- Begin Message ---
>
>
>
> Subject: 
>
> Re: bug#13448: Cannot build Emacs 24.2.92
>
>
>
>
> Date: 
>
> Tue, 15 Jan 2013 13:30:21 -0800
>
>
>
>
> User-agent: 
>
> Mozilla/5.0 (X11; Linux x86_64;	rv:17.0) Gecko/17.0 Thunderbird/17.0
>
>
>
>
> Enabling link time optimization is a common enough need and
> there's a simple fix that I think makes Emacs a bit clearer,
> so I pushed the following patch to the trunk as bzr 111533
> and I'm marking this as done.
>
> The original problem feels like it might be a GCC problem --
> GCC shouldn't be dumber (and presumably generate worse code)
> merely because link-time optimization is enabled.  Do you
> have the time to file a GCC bug report?
>
> === modified file 'lib-src/ChangeLog'
> --- lib-src/ChangeLog   2013-01-02 16:13:04 +0000
> +++ lib-src/ChangeLog   2013-01-15 21:24:53 +0000
> @@ -1,3 +1,9 @@
> +2013-01-15  Paul Eggert  <address@hidden>
> +
> +       * make-docfile.c (write_globals): Make it a bit clearer (Bug#13448).
> +       This pacifies GCC 4.7.2 when Emacs is configured with
> +       --enable-link-time-optimization and --enable-gcc-warnings.
> +
>  2013-01-01  Juanma Barranquero  <address@hidden>
>  
>         * makefile.w32-in (lisp1): Add macroexp.elc (bug#13320).
>
> === modified file 'lib-src/make-docfile.c'
> --- lib-src/make-docfile.c      2013-01-01 09:11:05 +0000
> +++ lib-src/make-docfile.c      2013-01-15 21:23:34 +0000
> @@ -624,7 +624,7 @@
>    qsort (globals, num_globals, sizeof (struct global), compare_globals);
>    for (i = 0; i < num_globals; ++i)
>      {
> -      char const *type;
> +      char const *type = 0;
>  
>        switch (globals[i].type)
>         {
> @@ -649,7 +649,7 @@
>           fatal ("not a recognized DEFVAR_", 0);
>         }
>  
> -      if (globals[i].type != FUNCTION)
> +      if (type)
>         {
>           fprintf (outfile, "  %s f_%s;\n", type, globals[i].name);
>           fprintf (outfile, "#define %s globals.f_%s\n",
>
>
>
> --- End Message ---