|
From: | GNU bug Tracking System |
Subject: | [debbugs-tracker] bug#14548: closed (24.3.1; [PATCH] image-dired-dired-toggle-marked-thumbs conflicts with other modes using overlays) |
Date: | Thu, 13 Jun 2013 05:12:02 +0000 |
Your message dated Thu, 13 Jun 2013 01:11:10 -0400 with message-id <address@hidden> and subject line Re: bug#14548: 24.3.1; [PATCH] image-dired-dired-toggle-marked-thumbs conflicts with other modes using overlays has caused the debbugs.gnu.org bug report #14548, regarding 24.3.1; [PATCH] image-dired-dired-toggle-marked-thumbs conflicts with other modes using overlays to be marked as done. (If you believe you have received this mail in error, please contact address@hidden) -- 14548: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=14548 GNU Bug Tracking System Contact address@hidden with problems
--- Begin Message ---Subject: 24.3.1; [PATCH] image-dired-dired-toggle-marked-thumbs conflicts with other modes using overlays Date: Mon, 3 Jun 2013 14:28:28 +0100 One such mode is stripe-buffer, which can be fonud here:the definition below fixes the problem.Evgeni(ad-unadvise 'image-dired-dired-toggle-marked-thumbs) ; stripe-buffer monkey-patches the function.(defun image-dired-dired-toggle-marked-thumbs (&optional arg)"Toggle thumbnails in front of file names in the dired buffer.If no marked file could be found, insert or hide thumbnails on thecurrent line. ARG, if non-nil, specifies the files to use insteadof the marked files. If ARG is an integer, use the next ARG (orprevious -ARG, if ARG<0) files."(interactive "P")(dired-map-over-marks(let* ((image-pos (dired-move-to-filename))(image-file (dired-get-filename nil t))thumb-fileoverlay)(when (and image-file(string-match-p (image-file-name-regexp) image-file))(setq thumb-file (image-dired-get-thumbnail-image image-file));; If image is not already added, then add it.(let* (( cur-ovs (overlays-in (point) (1+ (point))))( thumb-ov (car (cl-remove-if-not(lambda (ov) (overlay-get ov 'thumb-file))cur-ovs))))(if thumb-ov(delete-overlay thumb-ov)(progn(put-image thumb-file image-pos)(setq overlay(cl-loop for o in (overlays-in (point) (1+ (point)))when (overlay-get o 'put-image) collect o into ovfinally return (car ov)))(overlay-put overlay 'image-file image-file)(overlay-put overlay 'thumb-file thumb-file))))))arg ; Show or hide image on ARG next files.'show-progress) ; Update dired display after each image is updated.(add-hook 'dired-after-readin-hook'image-dired-dired-after-readin-hook nil t))
--- End Message ---
--- Begin Message ---Subject: Re: bug#14548: 24.3.1; [PATCH] image-dired-dired-toggle-marked-thumbs conflicts with other modes using overlays Date: Thu, 13 Jun 2013 01:11:10 -0400 User-agent: Gnus (www.gnus.org), GNU Emacs (www.gnu.org/software/emacs/) Version: 24.4 Applied in this form. > *** lisp/image-dired.el 2013-02-17 00:45:53 +0000 > --- lisp/image-dired.el 2013-06-11 19:00:18 +0000 > *************** > *** 657,665 **** > (string-match-p (image-file-name-regexp) image-file)) > (setq thumb-file (image-dired-get-thumbnail-image image-file)) > ;; If image is not already added, then add it. > ! (let ((cur-ov (overlays-in (point) (1+ (point))))) > ! (if cur-ov > ! (delete-overlay (car cur-ov)) > (put-image thumb-file image-pos) > (setq overlay > (cl-loop for o in (overlays-in (point) (1+ (point))) > --- 657,668 ---- > (string-match-p (image-file-name-regexp) image-file)) > (setq thumb-file (image-dired-get-thumbnail-image image-file)) > ;; If image is not already added, then add it. > ! (let* ((cur-ovs (overlays-in (point) (1+ (point)))) > ! (thumb-ov (car (cl-remove-if-not > ! (lambda (ov) (overlay-get ov 'thumb-file)) > ! cur-ovs)))) > ! (if thumb-ov > ! (delete-overlay thumb-ov) > (put-image thumb-file image-pos) > (setq overlay > (cl-loop for o in (overlays-in (point) (1+ (point)))
--- End Message ---
[Prev in Thread] | Current Thread | [Next in Thread] |