[debbugs-tracker] bug#15128: closed (24.3.50; python.el completion broken)

[GNU bug Tracking System]

Your message dated Mon, 02 Sep 2013 10:15:14 -0300
with message-id <address@hidden>
and subject line 24.3.50; python.el completion broken
has caused the debbugs.gnu.org bug report #15128,
regarding 24.3.50; python.el completion broken
to be marked as done.

(If you believe you have received this mail in error, please contact
address@hidden)


-- 
15128: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=15128
GNU Bug Tracking System
Contact address@hidden with problems
> --- Begin Message ---
>
>
>
> Subject: 
>
> 24.3.50; python.el completion broken
>
>
>
>
> Date: 
>
> Mon, 19 Aug 2013 02:44:15 +0200
>
>
>
>
> User-agent: 
>
> Gnus/5.13 (Gnus v5.13) Emacs/24.3.50 (gnu/linux)
>
>
>
>
> Hi,
>
> With Christopher Schmidt's comint changes on 2013-08-08 python.el
> completion breaks.  To reproduce do
>
> emacs -q
> M-x run-python
> x [TAB]
>
> I've included a simple fix that may or may not be sufficient. Here's
> the diff -c output
>
> *** python.el   2013-08-19 02:13:21.822104349 +0200
> --- python1.el  2013-08-19 02:13:52.323300415 +0200
> ***************
> *** 2276,2283 ****
>             ;; heuristic.
>             (with-current-buffer (process-buffer process)
>               (buffer-substring-no-properties
> !              (overlay-start comint-last-prompt-overlay)
> !              (overlay-end comint-last-prompt-overlay))))
>            (completion-context
>             ;; Check whether a prompt matches a pdb string, an import
>             ;; statement or just the standard prompt and use the
> --- 2276,2283 ----
>             ;; heuristic.
>             (with-current-buffer (process-buffer process)
>               (buffer-substring-no-properties
> !              (marker-position (car comint-last-prompt))
> !              (marker-position (cdr comint-last-prompt)))))
>            (completion-context
>             ;; Check whether a prompt matches a pdb string, an import
>             ;; statement or just the standard prompt and use the
>
> Here's a changelog, if needed.
>
> 2013-08-19  Rasmus Pank Roulund  <address@hidden>
>
>         * progmodes/python.el (python-shell-completion-get-completions):
>         Replace reference to comint-last-prompt-overlay with
>         comint-last-prompt.
>
> Let me know if I did something wrong!
>
> –Rasmus
>
> In GNU Emacs 24.3.50.1 (x86_64-unknown-linux-gnu, GTK+ Version 3.8.2)
>  of 2013-08-17 on pank
> Bzr revision: address@hidden
> Windowing system distributor `The X.Org Foundation', version 11.0.11402000
> System Description:     Arch Linux
>
>
>
> --- End Message ---
> --- Begin Message ---
>
>
>
> Subject: 
>
> 24.3.50; python.el completion broken
>
>
>
>
> Date: 
>
> Mon, 02 Sep 2013 10:15:14 -0300
>
>
>
>
> User-agent: 
>
> mu4e 0.9.9.5; emacs 24.3.1
>
>
>
>
> Hello Rasmus,
>
> I fixed this in revno 114094. I took a different approach, avoiding use
> of the comint-last-prompt* vars in a way to keep compatiblity with Emacs
> 24.x.
>
>
> Regards,
> Fabián.
>
>
> --- End Message ---