emacs-bug-tracker
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[debbugs-tracker] bug#15200: closed (isearch-other-meta-char and shift)


From: GNU bug Tracking System
Subject: [debbugs-tracker] bug#15200: closed (isearch-other-meta-char and shift)
Date: Tue, 08 Oct 2013 23:30:03 +0000

Your message dated Wed, 09 Oct 2013 02:29:15 +0300
with message-id <address@hidden>
and subject line Re: bug#15200: isearch-other-meta-char and shift
has caused the debbugs.gnu.org bug report #15200,
regarding isearch-other-meta-char and shift
to be marked as done.

(If you believe you have received this mail in error, please contact
address@hidden)


-- 
15200: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=15200
GNU Bug Tracking System
Contact address@hidden with problems
--- Begin Message --- Subject: isearch-other-meta-char and shift Date: Tue, 27 Aug 2013 19:28:22 +0300 User-agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3.50 (x86_64-pc-linux-gnu)
There is a problem in `isearch-other-meta-char' with shifted characters.
Typing <S-kp-0> exits Isearch instead of adding 0 to the search string.

A possible fix is to handle shifted kp-numbers like
shifted control characters are handled in the second
`cond' branch of `isearch-other-meta-char':

=== modified file 'lisp/isearch.el'
--- lisp/isearch.el     2013-07-05 20:15:32 +0000
+++ lisp/isearch.el     2013-08-27 16:27:45 +0000
@@ -2550,6 +2606,16 @@ (defun isearch-other-meta-char (&optiona
                    (lookup-key local-function-key-map key)))
             (while keylist
               (setq key (car keylist))
+              ;; Handle an undefined shifted printing character
+              ;; by downshifting it if that makes it printing.
+              ;; (As read-key-sequence would normally do,
+              ;; if we didn't have a default definition.)
+              (if (and (integerp key)
+                       (memq 'shift (event-modifiers key))
+                       (>= key (+ ?\s (- ?\S-a ?a)))
+                       (/= key (+ 127 (- ?\S-a ?a)))
+                       (<  key (+ 256 (- ?\S-a ?a))))
+                  (setq key (- key (- ?\S-a ?a))))
               ;; If KEY is a printing char, we handle it here
               ;; directly to avoid the input method and keyboard
               ;; coding system translating it.




--- End Message ---
--- Begin Message --- Subject: Re: bug#15200: isearch-other-meta-char and shift Date: Wed, 09 Oct 2013 02:29:15 +0300 User-agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3.50 (x86_64-pc-linux-gnu)
>> (lookup-key isearch-mode-map (kbd "C-u C-l")) => 1
>> (lookup-key isearch-mode-map (kbd "C-u C-w")) => 1
>
>> both return 1.
>
> OK, don't worry about that: the fix needs to be elsewhere (I happen to
> have a work-in-progress patch which fixes that problem).
>
> So, I think you can go ahead and install your patch.
> And please make a bug-report for the C-u C-w problem, so we don't forget
> about it.

I installed the patch (with a FIXME comment) and reported a new bug#15568.


--- End Message ---

reply via email to

[Prev in Thread] Current Thread [Next in Thread]