|
From: | GNU bug Tracking System |
Subject: | [debbugs-tracker] bug#16151: closed (margin does not respect face-remapping-alist. no margin face.) |
Date: | Sun, 15 Dec 2013 17:05:02 +0000 |
Your message dated Sun, 15 Dec 2013 19:03:39 +0200 with message-id <address@hidden> and subject line Re: bug#16151: margin does not respect face-remapping-alist. no margin face. has caused the debbugs.gnu.org bug report #16151, regarding margin does not respect face-remapping-alist. no margin face. to be marked as done. (If you believe you have received this mail in error, please contact address@hidden) -- 16151: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=16151 GNU Bug Tracking System Contact address@hidden with problems
--- Begin Message ---Subject: margin does not respect face-remapping-alist. no margin face. Date: Sat, 14 Dec 2013 17:30:17 -0500
Emacs -QThen:(linum-mode 1)(setq face-remapping-alist '((default . custom-invalid)))Observe that the empty space in the left margin is white, rather than red. See attached screenshot.The left (and presumably right) margins seem to use the default face, but fail to take `face-remapping-alist' into account.It would not hurt to have a `margins' face, but even then, remapping should be observed.This is an up to date build.
In GNU Emacs 24.3.50.4 (x86_64-apple-darwin13.0.0, NS apple-appkit-1265.00)
of 2013-12-14 on momo
Windowing system distributor `Apple', version 10.3.1265
Configured using:
`configure --with-ns'
--- End Message ---
--- Begin Message ---Subject: Re: bug#16151: margin does not respect face-remapping-alist. no margin face. Date: Sun, 15 Dec 2013 19:03:39 +0200 > From: David Reitter <address@hidden> > Date: Sat, 14 Dec 2013 17:30:17 -0500 > > Emacs -Q > > Then: > > (linum-mode 1) > (setq face-remapping-alist '((default . custom-invalid))) (I'm guessing this wasn't exactly "emacs -Q", because custom-invalid face is not known in 'emacs -Q", at least on my system.) > Observe that the empty space in the left margin is white, rather than red. > See attached screenshot. > > The left (and presumably right) margins seem to use the default face, but > fail to take `face-remapping-alist' into account. No, they do take the face remapping into account. Otherwise, how could you have the correct face where the line numbers _are_ written in the margin, as clearly seen in your screenshots? The problem was that the empty margin area was not filled with the background of the default face, whether remapped or not, like we do with the text area. This was never supported in Emacs, the code to do that was simply never written. Now this works, starting from trunk revision 115535. > It would not hurt to have a `margins' face ??? What is shown in the margins is display strings which have to be hand-crafted anyway, so you can have any face you want there, just propertize the string accordingly. Why do we need another face? Thanks.
--- End Message ---
[Prev in Thread] | Current Thread | [Next in Thread] |