[debbugs-tracker] bug#16143: closed (24.3.50; [PATCH] eww: fixed wrong key bind to eww-toggle-checkbox)

[GNU bug Tracking System]

Your message dated Sat, 21 Dec 2013 15:50:39 -0500
with message-id <address@hidden>
and subject line Re: bug#16143: 24.3.50; [PATCH] eww: fixed wrong key bind to 
eww-toggle-checkboxx
has caused the debbugs.gnu.org bug report #16143,
regarding 24.3.50; [PATCH] eww: fixed wrong key bind to eww-toggle-checkbox
to be marked as done.

(If you believe you have received this mail in error, please contact
address@hidden)


-- 
16143: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=16143
GNU Bug Tracking System
Contact address@hidden with problems
> --- Begin Message ---
>
>
>
> Subject: 
>
> 24.3.50; [PATCH] eww: fixed wrong key bind to eww-toggle-checkbox
>
>
>
>
> Date: 
>
> Sat, 14 Dec 2013 21:35:06 +0900
>
>
>
>
> User-agent: 
>
> mu4e 0.9.9.6pre2; emacs 24.3.50.2
>
>
>
>
> Keybind of the toggle-checkbox with space key is wrong.
> I am sorry If I'm wrong. The key bind [space] can not work in my
> environment.
>
> Signed-off-by: Kenjiro NAKAYAMA <address@hidden>
>
>         * net/eww.el (eww-checkbox-map): fixed wrong key bind to 
> eww-toggle-checkbox
>
> ---
>  lisp/net/eww.el | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/lisp/net/eww.el b/lisp/net/eww.el
> index 34c6728..a6447f2 100644
> --- a/lisp/net/eww.el
> +++ b/lisp/net/eww.el
> @@ -563,7 +563,7 @@ appears in a <link> or <a> tag."
>
>  (defvar eww-checkbox-map
>    (let ((map (make-sparse-keymap)))
> -    (define-key map [space] 'eww-toggle-checkbox)
> +    (define-key map " " 'eww-toggle-checkbox)
>      (define-key map "\r" 'eww-toggle-checkbox)
>      (define-key map [(control c) (control c)] 'eww-submit)
>      map))
> -- 
> 1.8.3.1
>
>
>
>
> --- End Message ---
> --- Begin Message ---
>
>
>
> Subject: 
>
> Re: bug#16143: 24.3.50; [PATCH] eww: fixed wrong key bind to eww-toggle-checkboxx
>
>
>
>
> Date: 
>
> Sat, 21 Dec 2013 15:50:39 -0500
>
>
>
>
> User-agent: 
>
> Gnus/5.130008 (Ma Gnus v0.8) Emacs/24.3.50 (gnu/linux)
>
>
>
>
> On Sun, 15 Dec 2013 01:22:07 +0900 Kenjiro NAKAYAMA <address@hidden> wrote: 
>
> KN> I resend my patch with a fixed comment.
> KN> Signed-off-by: Kenjiro NAKAYAMA <address@hidden>
>
> KN>         * net/eww.el (eww-checkbox-map): Fix wrong key bind to 
> eww-toggle-checkbox.
>
> Applied, thank you.
>
> Ted
>
>
> --- End Message ---