--- Begin Message ---
Subject: |
24.4.50; Recent changes to ert.el broke "make check" on trunk |
Date: |
Mon, 03 Dec 2012 13:36:28 +0800 |
`make check' fails on latest trunk due to this commit:
revno: 110983
committer: Stefan Monnier <address@hidden>
branch nick: trunk
timestamp: Thu 2012-11-22 22:26:09 -0500
message:
* emacs-lisp/ert.el, emacs-lisp/ert-x.el: Use cl-lib and lexical-binding.
The error condition is:
1 unexpected results:
FAILED ert-test-record-backtrace
Test ert-test-record-backtrace condition:
(ert-test-failed
((should
(equal first-line " signal(ert-test-failed (\"foo\"))"))
:form
(equal " (closure (ert--test-body-was-run t) nil (ert-fail \"foo\"))()"
" signal(ert-test-failed (\"foo\"))")
:value nil :explanation
(arrays-of-different-length 61 33 " (closure (ert--test-body-was-run t)
nil (ert-fail \"foo\"))()" " signal(ert-test-failed (\"foo\"))"
first-mismatch-at 2)))
In GNU Emacs 24.3.50.7 (x86_64-unknown-linux-gnu, GTK+ Version 3.4.2)
of 2012-12-02 on ulysses
Bzr revision: 111062 address@hidden
Windowing system distributor `The X.Org Foundation', version 11.0.11103000
System Description: Ubuntu 12.04.1 LTS
Configured using:
`configure '--with-x-toolkit=gtk3' 'CFLAGS=-g''
--- End Message ---
--- Begin Message ---
Subject: |
Re: bug#13064: 24.4.50; Recent changes to ert.el broke "make check" on trunk |
Date: |
Mon, 13 Jan 2014 11:58:06 +0100 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/24.3.50 (gnu/linux) |
Chong Yidong <address@hidden> writes:
> Test ert-test-record-backtrace condition:
> (ert-test-failed
> ((should
> (equal first-line " signal(ert-test-failed (\"foo\"))"))
> :form
> (equal " (closure (ert--test-body-was-run t) nil (ert-fail
> \"foo\"))()" " signal(ert-test-failed (\"foo\"))")
> :value nil :explanation
> (arrays-of-different-length 61 33 " (closure (ert--test-body-was-run
> t) nil (ert-fail \"foo\"))()" " signal(ert-test-failed (\"foo\"))"
> first-mismatch-at 2)))
I've changed the string to be checked for. It is still the same for more
than a year, so I regard it as stable.
Best regards, Michael.
--- End Message ---