|
From: | GNU bug Tracking System |
Subject: | [debbugs-tracker] bug#16843: closed (Error caused due to regression in git) |
Date: | Mon, 24 Feb 2014 20:12:03 +0000 |
Your message dated Mon, 24 Feb 2014 13:11:34 -0700 with message-id <address@hidden> and subject line Re: bug#16843: Error caused due to regression in git has caused the debbugs.gnu.org bug report #16843, regarding Error caused due to regression in git to be marked as done. (If you believe you have received this mail in error, please contact address@hidden) -- 16843: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=16843 GNU Bug Tracking System Contact address@hidden with problems
--- Begin Message ---Subject: Error caused due to regression in git Date: Sat, 22 Feb 2014 10:01:21 +0100 I bisected the git source to find the commit causing the problems. The following is the commit message:returns an empty string which implies that git is unable to see the submodules correctly.$ git submodule foreach echo $name, $path, $sha1In the repository, gnulib is used as a submodule. Running:`make` works correctly, but `make check` happens to fail with the following output:The error occured when attempting to run the test suite GNU Wget's git source.automake --version: 1.14.1autoconf --version: 2.69
if test -d ./.git \
&& git --version >/dev/null 2>&1; then \
cd . && \
git submodule --quiet foreach \
test '"$(git rev-parse "$sha1")"' \
= '"$(git merge-base origin "$sha1")"' \
|| { echo 'maint.mk: found non-public submodule commit' >&2; \
exit 1; }; \
else \
: ; \
fi
Stopping at 'gnulib'; script returned non-zero status.
maint.mk: found non-public submodule commit
maint.mk:1394: recipe for target 'public-submodule-commit' failed
make: *** [public-submodule-commit] Error 1
commit 1c4fb136dbad762c9c4350ee79c3474ae8037587
Author: Anders Kaseorg <address@hidden>
Date: Fri Sep 27 06:23:55 2013 -0400
submodule foreach: skip eval for more than one argument
'eval "$@"' creates an extra layer of shell interpretation, which is
probably not expected by a user who passes multiple arguments to git
submodule foreach:
$ git grep "'"
[searches for single quotes]
$ git submodule foreach git grep "'"
Entering '[submodule]'
/usr/lib/git-core/git-submodule: 1: eval: Syntax error: Unterminated quoted string
Stopping at '[submodule]'; script returned non-zero status.
To fix this, if the user passes more than one argument, execute "$@"
directly instead of passing it to eval.
Examples:
* Typical usage when adding an extra level of quoting is to pass a
single argument representing the entire command to be passed to the
shell. This doesn't change that.
* One can imagine someone feeding untrusted input as an argument:
git submodule foreach git grep "$variable"
That currently results in a nonobvious shell code injection
vulnerability. Executing the command named by the arguments
directly, as in this patch, fixes it.
Signed-off-by: Anders Kaseorg <address@hidden>
Acked-by: Johan Herland <address@hidden>
Signed-off-by: Jonathan Nieder <address@hidden>Hence, this seems to me as a feature, not a bug in Git. Maybe, automake needs to fix its scripts accordingly? Because the issue with `make check` was introduced through this specific commit.
Do let me know if I can provide any more help.Also, I am not sunscribed to this mailing list, hence, please ensure to leave my email in the CC list.
--
Thanking You,
Darshit Shah
--- End Message ---
--- Begin Message ---Subject: Re: bug#16843: Error caused due to regression in git Date: Mon, 24 Feb 2014 13:11:34 -0700 User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.3.0 tag 16843 notabug thanks On 02/22/2014 02:01 AM, Darshit Shah wrote: > automake --version: 1.14.1 > autoconf --version: 2.69 > > The error occured when attempting to run the test suite GNU Wget's git > source. Then this bug should be filed against wget, not automake. I'm closing this bug in the automake tracker, as the fix is for wget to upgrade to a newer version of gnulib, and automake has no bearing on it. -- Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.orgsignature.asc
Description: OpenPGP digital signature
--- End Message ---
[Prev in Thread] | Current Thread | [Next in Thread] |