[debbugs-tracker] bug#17072: closed (dfa change apparently needed on Irix)

[GNU bug Tracking System]

Your message dated Sun, 06 Apr 2014 11:00:58 -0700
with message-id <address@hidden>
and subject line Re: bug#17072: dfa change apparently needed on Irix
has caused the debbugs.gnu.org bug report #17072,
regarding dfa change apparently needed on Irix
to be marked as done.

(If you believe you have received this mail in error, please contact
address@hidden)


-- 
17072: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=17072
GNU Bug Tracking System
Contact address@hidden with problems
> --- Begin Message ---
>
>
>
> Subject: 
>
> dfa change apparently needed on Irix
>
>
>
>
> Date: 
>
> Sun, 23 Mar 2014 21:32:21 +0200
>
>
>
>
> User-agent: 
>
> Heirloom mailx 12.5 6/20/10
>
>
>
>
> FYI
>
> Arnold
> -------------------
> > Date: Tue, 18 Mar 2014 13:44:57 -0600 (MDT)
> > From: "Nelson H. F. Beebe" <address@hidden>
> > To: "Arnold Robbins" <address@hidden>
> > Cc: address@hidden
> > Subject: gawk-4.1.0f: a patch for a failed build
> >
> > On SGI IRIX MIPS, gawk-4.1.0a had built and installed without problems
> > on 13-Dec-2013.  
> >
> > For gawk-4.1.0f, however, I had to make one source code patch:
> >
> > % diff -c dfa.c.org dfa.c
> > *** dfa.c.org   Mon Mar 10 14:39:05 2014
> > --- dfa.c       Mon Mar 17 18:04:46 2014
> > ***************
> > *** 43,49 ****
> >   #include "missing_d/gawkbool.h"
> >   #endif /* HAVE_STDBOOL_H */
> >   
> > - #include "dfa.h"
> >   
> >   /* Gawk doesn't use Gnulib, so don't assume static_assert is present.  */
> >   #ifndef static_assert
> > --- 43,48 ----
> > ***************
> > *** 89,94 ****
> > --- 88,95 ----
> >   
> >   #include "xalloc.h"
> >   
> > + #include "dfa.h"
> > + 
> >   #ifdef GAWK
> >   static int
> >   is_blank (int c)
> >
> > The reason for the patch is this error:
> >
> >       dfa.c:956: error: conflicting types for 'case_folded_counterparts'
> >       dfa.h:111: error: previous declaration of 'case_folded_counterparts' 
> > was here
> >       dfa.c:956: error: conflicting types for 'case_folded_counterparts'
> >
> > What happens is that the prototype for that function has wchar_t
> > arguments, but between the time that prototype is seen, and the first
> > reference to the function is seen, wchar_t has been changed to char.
> > Moving the inclusion of "dfa.h" later in "dfa.c" solved the problem.
> >
> > I configured and built like this:
> >
> > env CC='gcc -std=c99' CFLAGS=-D_SGI_SOURCE LDFLAGS='-L/usr/local/lib 
> > -Wl,-rpath,/usr/local/lib' ./configure && $B/make all check
>
>
>
> --- End Message ---

--- Begin Message --- Subject: Re: bug#17072: dfa change apparently needed on Irix Date: Sun, 06 Apr 2014 11:00:58 -0700 User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.4.0 Thanks to Nelson H.F. Beebe's machines I've reproduced Bug#17072 on IRIX and have verified that the attached gawk patch fixes it. This patch is almost identical to the gawk patch I submitted in <http://bugs.gnu.org/17157#44>. It improves on the earlier patch only by changing gawk's dfa.c to look more like grep's dfa.c in one more way: include "dfa.h" before all other include files (except config.h).

I'll CC: this to Bug#17157 so that the patch is visible there too. No further change should be needed to grep for this.

0001-awk-simplify-dfa.c-by-having-it-not-include-mbsuppor.patch
Description: Text document

--- End Message ---