|
From: | GNU bug Tracking System |
Subject: | [debbugs-tracker] bug#17136: closed ([PATCH] dfa: speed up memory allocation, port to IRIX) |
Date: | Fri, 18 Apr 2014 06:00:03 +0000 |
Your message dated Thu, 17 Apr 2014 22:59:17 -0700 with message-id <address@hidden> and subject line Re: bug#17136: [PATCH] dfa: speed up memory allocation, port to IRIX has caused the debbugs.gnu.org bug report #17136, regarding [PATCH] dfa: speed up memory allocation, port to IRIX to be marked as done. (If you believe you have received this mail in error, please contact address@hidden) -- 17136: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=17136 GNU Bug Tracking System Contact address@hidden with problems
--- Begin Message ---Subject: [PATCH] dfa: speed up memory allocation, port to IRIX Date: Fri, 28 Mar 2014 18:28:57 -0700 User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.4.0 Tags: patchI'm not going to install the attached memory-management changes yet, as they're fairly intrusive and I want to give them a chance to cool off. The benefits are minor but are there, e.g., this shrinks the overall grep text size by 1.2% on my platform (Fedora 20 x86-64). Mostly, though, I wanted the memory management to be clearer.0001-dfa-speed-up-memory-allocation-port-to-IRIX.patch
Description: Text document
--- End Message ---
--- Begin Message ---Subject: Re: bug#17136: [PATCH] dfa: speed up memory allocation, port to IRIX Date: Thu, 17 Apr 2014 22:59:17 -0700 I merged that patch into the grep trunk and am closing this bug report. While merging, I removed one part of the patch that had a small but measurable performance degradation, namely, the introduction of struct dfatab. I found some other minor simplifications and threw them in. There seems to be no significant change in CPU performance. The patch's causes the dfa module's text size to shrink by 8% on my platform (x86-64 Fedora 20), which I suppose is a small win, but the main point of the patch is simplifying the source. I'm attaching what I installed, broken into 12 little patches to ease review. User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.4.0 0001-dfa-clarify-memory-allocation-and-port-to-IRIX.patch
Description: Text document0002-dfa-avoid-unnecessary-work-and-other-initialization.patch
Description: Text document0003-dfa-better-size-overflow-check.patch
Description: Text document0004-dfa-simplify-transition-table-allocation.patch
Description: Text document0005-dfa-simplify-range-char-allocation.patch
Description: Text document0006-dfa-simplify-multibyte_prop-allocation.patch
Description: Text document0007-dfa-simplify-position-set-and-element-count-allocati.patch
Description: Text document0008-dfa-simplify-memory-allocation.patch
Description: Text document0009-dfa-avoid-duplicate-strlen-when-allocating-memory.patch
Description: Text document0010-dfa-simplify-freelist.patch
Description: Text document0011-dfa-simplify-dfmust-initialization.patch
Description: Text document0012-dfa-trans-reallocation-microoptimization.patch
Description: Text document
--- End Message ---
[Prev in Thread] | Current Thread | [Next in Thread] |