[debbugs-tracker] bug#17141: closed ([PATCH] tests: fix t2310-dos-extended-2-sector-min-offset.sh)

[GNU bug Tracking System]

Your message dated Fri, 18 Apr 2014 13:38:03 -0400
with message-id <address@hidden>
and subject line Re: bug#17141: [PATCH] tests: fix 
t2310-dos-extended-2-sector-min-offset.sh
has caused the debbugs.gnu.org bug report #17141,
regarding [PATCH] tests: fix t2310-dos-extended-2-sector-min-offset.sh
to be marked as done.

(If you believe you have received this mail in error, please contact
address@hidden)


-- 
17141: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=17141
GNU Bug Tracking System
Contact address@hidden with problems
> --- Begin Message ---
>
>
>
> Subject: 
>
> [PATCH] tests: fix t2310-dos-extended-2-sector-min-offset.sh
>
>
>
>
> Date: 
>
> Sat, 29 Mar 2014 16:31:39 -0400
>
>
>
>
> This test was ignoring the requested sector size and always using
> 512 bytes per sector.  Fix it to use the requested sector size.
> ---
>  tests/t2310-dos-extended-2-sector-min-offset.sh | 9 +++------
>  1 file changed, 3 insertions(+), 6 deletions(-)
>
> diff --git a/tests/t2310-dos-extended-2-sector-min-offset.sh 
> b/tests/t2310-dos-extended-2-sector-min-offset.sh
> index f74cba5..53843ab 100644
> --- a/tests/t2310-dos-extended-2-sector-min-offset.sh
> +++ b/tests/t2310-dos-extended-2-sector-min-offset.sh
> @@ -23,7 +23,8 @@ require_root_
>  require_scsi_debug_module_
>  
>  # create memory-backed device
> -scsi_debug_setup_ dev_size_mb=1 > dev-name ||
> +ss=$sector_size_
> +scsi_debug_setup_ sector_size=$ss dev_size_mb=1 > dev-name ||
>    skip_ 'failed to create scsi_debug device'
>  scsi_dev=$(cat dev-name)
>  p1=${scsi_dev}1
> @@ -31,15 +32,11 @@ p5=${scsi_dev}5
>  
>  cat <<EOF > exp || framework_failure
>  BYT;
> -$scsi_dev:2048s:scsi:512:512:msdos:Linux scsi_debug:;
> +$scsi_dev:$((2048*512/$ss))s:scsi:$ss:$ss:msdos:Linux scsi_debug:;
>  1:64s:128s:65s:::lba;
>  5:65s:128s:64s:::;
>  EOF
>  
> -cat <<EOF > err.exp || framework_failure
> -Error: Partition(s) 5 on $scsi_dev have been written, but we have been unable 
> to inform the kernel of the change, probably because it/they are in use.  As a 
> result, the old partition(s) will remain in use.  You should reboot now before 
> making further changes.
> -EOF
> -
>  # Create a DOS label with an extended partition starting at sector 64.
>  parted -s $scsi_dev mklabel msdos || fail=1
>  parted --align=min -s $scsi_dev mkpart extended 64s 128s> out 2>&1 || fail=1
> -- 
> 1.8.3.2
>
>
>
>
> --- End Message ---
> --- Begin Message ---
>
>
>
> Subject: 
>
> Re: bug#17141: [PATCH] tests: fix t2310-dos-extended-2-sector-min-offset.sh
>
>
>
>
> Date: 
>
> Fri, 18 Apr 2014 13:38:03 -0400
>
>
>
>
> User-agent: 
>
> Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.4.0
>
>
>
>
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA512
>
> On 04/17/2014 06:14 PM, Brian C. Lane wrote:
> > On Sat, Mar 29, 2014 at 04:31:39PM -0400, Phillip Susi wrote:
> >> This test was ignoring the requested sector size and always
> >> using 512 bytes per sector.  Fix it to use the requested sector
> >> size. --- tests/t2310-dos-extended-2-sector-min-offset.sh | 9
> >> +++------ 1 file changed, 3 insertions(+), 6 deletions(-)
> > 
> > Ack
>
> pushed.
>
> -----BEGIN PGP SIGNATURE-----
> Version: GnuPG v1
> Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/
>
> iQEcBAEBCgAGBQJTUWL7AAoJEI5FoCIzSKrwFXUH/3qLC0qO8/3g2yvyCzw1w+5x
> q79lHFg+XwwTYEHj3erbMFbuk0ofiu/w1o7R/qN16yjRZMe3NM9qw0AoGLlJ2e2H
> pSmyCST1dLgslRneQCb7/WlF0SWR0K64GmEyjeUsfnx5/TKO/GUdIbBdkFl5A7gs
> Y2hqkCwTru9l4nJPvHPRpW6lm0ixnRTla6LwPHyewM7v1KJqCTSwzF9VZNFWMSud
> YzuvYmTKhPIyE6JSfbsxyWXsFHzmT1mmIE6+mXpTaK1BFZLRFrZnjZ5a4zjpkIcm
> Mf3NCKDtJSxQaI2cCNtbkPaUw2CUYstvrvDo+zoMdbNKd+iJMmmoZ8lbNClO6Ms=
> =09gT
> -----END PGP SIGNATURE-----
>
>
> --- End Message ---