[debbugs-tracker] bug#17230: closed ([PATCH 1/2] grep: may also use Boyer-Moore algorithm for case-insensitive matching)

[GNU bug Tracking System]

Your message dated Tue, 22 Apr 2014 21:20:59 -0700
with message-id <address@hidden>
and subject line Re: bug#17230: [PATCH 1/2] grep: may also use Boyer-Moore 
algorithm for case-insensitive matching
has caused the debbugs.gnu.org bug report #17230,
regarding [PATCH 1/2] grep: may also use Boyer-Moore algorithm for 
case-insensitive matching
to be marked as done.

(If you believe you have received this mail in error, please contact
address@hidden)


-- 
17230: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=17230
GNU Bug Tracking System
Contact address@hidden with problems

--- Begin Message --- Subject: [PATCH 1/2] grep: may also use Boyer-Moore algorithm for case-insensitive matching Date: Wed, 09 Apr 2014 22:54:42 +0900

Boyer-Moore algorithm is faster than Beate Commentz-Walter, in especially
worst case, because Galil rule is applicable only for Boyer-Moore
algorithm.

This patch enables to use Boyer-Moore algorithm for case-insensitive
matching.

Norihiro

patch.txt
Description: Text document

--- End Message ---

--- Begin Message --- Subject: Re: bug#17230: [PATCH 1/2] grep: may also use Boyer-Moore algorithm for case-insensitive matching Date: Tue, 22 Apr 2014 21:20:59 -0700 User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.4.0 Thanks much for this performance improvement. I puzzled for a while to figure out what was going on, and was confused by that tricky macro expansion. Nowadays functions are typically not significantly slower than macros, so unless there's a major performance difference I'd prefer to use functions. I installed the performance improvement patch and followed up with the attached patch, which uses C functions instead of macros and which coalesces some of the near-duplicate code. The followup patch also includes some comments to try to explain the new functions.

0001-kwset-simplify-Boyer-Moore-with-unibyte-i.patch
Description: Text document

--- End Message ---