[debbugs-tracker] bug#17700: closed ([PATCH] dfa: speed-up for a pattern that many atoms are catenated)

[GNU bug Tracking System]

Your message dated Fri, 06 Jun 2014 22:19:13 +0900
with message-id <address@hidden>
and subject line Re: bug#17700: [PATCH] dfa: speed-up for a pattern that many 
atoms are catenated
has caused the debbugs.gnu.org bug report #17700,
regarding [PATCH] dfa: speed-up for a pattern that many atoms are catenated
to be marked as done.

(If you believe you have received this mail in error, please contact
address@hidden)


-- 
17700: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=17700
GNU Bug Tracking System
Contact address@hidden with problems

--- Begin Message --- Subject: [PATCH] dfa: speed-up for a pattern that many atoms are catenated Date: Thu, 05 Jun 2014 20:32:44 +0900

When many atoms are catenated, dfamust() is very slow in order that
pushing a string into `in' list is slow.  This change fixes it.

I tested below to confirm the effect.

  $ printf '%08192d\n' 0 | time -p src/grep -f - /dev/null

0001-dfa-speed-up-for-a-pattern-that-many-atoms-are-caten.patch
Description: Text document

--- End Message ---

> --- Begin Message ---
>
>
>
> Subject: 
>
> Re: bug#17700: [PATCH] dfa: speed-up for a pattern that many atoms are catenated
>
>
>
>
> Date: 
>
> Fri, 06 Jun 2014 22:19:13 +0900
>
>
>
>
> Paul Eggert wrote:
> > So it looks like your patch confers some advantage, but on my platform
> > almost all the speedup is achieved simply by switching to the system strstr.
>
> First, I tested on CentOS 5.10.  Next, I tested on RHEL 6.5, and get
> result as same as you.  strstr() on CentOS 5.10 may be too old.  I'm
> sure that this bug has already been fixed.  So closing.
>
> Thanks,
> Norihiro
>
>
>
> --- End Message ---