[debbugs-tracker] bug#17970: closed (log-edit creates unwanted ChangeLog buffers)

[GNU bug Tracking System]

Your message dated Wed, 09 Jul 2014 14:54:57 -0400
with message-id <address@hidden>
and subject line Re: bug#17970: log-edit creates unwanted ChangeLog buffers
has caused the debbugs.gnu.org bug report #17970,
regarding log-edit creates unwanted ChangeLog buffers
to be marked as done.

(If you believe you have received this mail in error, please contact
address@hidden)


-- 
17970: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=17970
GNU Bug Tracking System
Contact address@hidden with problems
> --- Begin Message ---
>
>
>
> Subject: 
>
> log-edit creates unwanted ChangeLog buffers
>
>
>
>
> Date: 
>
> Mon, 07 Jul 2014 22:35:39 -0400
>
>
>
>
> User-agent: 
>
> Gnus (www.gnus.org), GNU Emacs (www.gnu.org/software/emacs/)
>
>
>
>
> Package: emacs
> Version: 24.3.92
> Severity: minor
>
> ## Just making a test repo:
> mkdir /tmp/foo
> cd /tmp/foo
> bzr init
> touch 1
> bzr add 1
>
> emacs -Q 1
> C-x v v
> enter some log message
> C-c C-c
>
> C-x C-b
>   -> Now there is an empty, unwanted "/tmp/foo/ChangeLog" buffer.
>
>
> I wish it would not create the ChangeLog buffer (especially when the
> the repo does not use ChangeLogs).
>
> Emacs 24.3 does not create these buffers.
>
>
>
> --- End Message ---
> --- Begin Message ---
>
>
>
> Subject: 
>
> Re: bug#17970: log-edit creates unwanted ChangeLog buffers
>
>
>
>
> Date: 
>
> Wed, 09 Jul 2014 14:54:57 -0400
>
>
>
>
> User-agent: 
>
> Gnus/5.13 (Gnus v5.13) Emacs/24.4.50 (gnu/linux)
>
>
>
>
> > C-x C-b
> -> Now there is an empty, unwanted "/tmp/foo/ChangeLog" buffer.
>
> I installed the patch below which seems to fix this problem.
>
>
>         Stefan
>
>
> === modified file 'lisp/vc/log-edit.el'
> --- lisp/vc/log-edit.el 2014-07-01 15:15:03 +0000
> +++ lisp/vc/log-edit.el 2014-07-09 18:52:47 +0000
> @@ -905,6 +905,7 @@
>               ;; that memoizing which is undesired here.
>               (setq change-log-default-name nil)
>               (find-change-log)))))
> +    (when (file-exists-p changelog-file-name)
>      (with-current-buffer (find-file-noselect changelog-file-name)
>        (unless (eq major-mode 'change-log-mode) (change-log-mode))
>        (goto-char (point-min))
> @@ -942,7 +943,7 @@
>                    (setq pos (max (1+ pos) (elt entry 1)))
>                   (goto-char pos)))
>  
> -             (cons (current-buffer) texts))))))))
> +                (cons (current-buffer) texts)))))))))
>  
>  (defun log-edit-changelog-insert-entries (buffer beg end &rest files)
>    "Insert the text from BUFFER between BEG and END.
>
>
>
> --- End Message ---