--- Begin Message ---
|
Subject: |
FAIL: tests/du/bind-mount-dir-cycle --- patch attached |
|
Date: |
Wed, 18 Dec 2013 20:43:37 -0500 |
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
Hi-
I'm resending this since it didn't seem to go through the first
time; also, I think I have a solution.
This test fails on my system (Linux 3.7.10 kernel, glibc-2.17);
apparently "du a" is giving as output :
du: WARNING: Circular directory structure.
This almost certainly means that you have a corrupted file system.
NOTIFY YOUR SYSTEM MANAGER.
The following directory is part of the cycle:
'a/b'
instead of the expected
du: mount point 'a/b' already traversed
Apparently, ./configure is assuming I don't have hasmntopt(), which
has become an issue because lib/mountlist.c now protects hasmntopt()
with #defines
I've attached a patch, but I don't have autoconf; so someone who
does should test it before committing it.
Yours,
Andrew Warshall
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.13 (GNU/Linux)
iQEcBAEBAgAGBQJSsk9JAAoJEESPRWh79T7tp6gIALzKEynBq3TN+kVR1jHQ7VNt
6SyVjn6N62wNcJfu2x81RRtOcU/ZpqoFOw2ygF+cCSblsm0Ji8M8z4vFq/c79Lrn
Luq0N8DG/WjYmFPMuKmo8ji8Dyn5xJBkHn6Xby/P9819N4vqKM++TAXg7a2RjidM
yVJgXaLJTy5VUpjO7bqGUEP6T61GkEzdnW9syE8cZs/mZhJfqlvHJKJaIHdVFwFX
nDNsI9Rcfy0QS65y5oeVkcEHOflBX1sGAP5y5E3xIaHEekmOSPQF74+teoRYLrJl
/he9DNnKQcR8AFRXdFSc0Ozn567I8c1rKNMv9BLyd/HHUrpZhwed1Znq1nin7Zs=
=oARV
-----END PGP SIGNATURE-----
coreutils-8.22-hasmntopt.patch
Description: Binary data
--- End Message ---
--- Begin Message ---
|
Subject: |
Re: bug#17833: coreutils 8.22 df |
|
Date: |
Wed, 09 Jul 2014 11:06:13 +0100 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130110 Thunderbird/17.0.2 |
On 07/09/2014 10:18 AM, Pádraig Brady wrote:
> Apologies for resend. GNU mailers were having issues yesterday...
>
> On 06/25/2014 01:24 PM, Gabor Z. Papp wrote:
>> * Pádraig Brady <address@hidden>:
>>
>> | > $ cat /etc/mtab
>> | > /dev/md0 / ext3 rw,errors=remount-ro 0 0
>> | > proc /proc proc rw,relatime 0 0
>> | > sysfs /sys sysfs rw,relatime 0 0
>> | > tmpfs /dev tmpfs rw,relatime,size=4k,mode=755 0 0
>> | > devpts /dev/pts devpts rw,relatime,mode=620 0 0
>> | > /dev/md1 /var/archive ext3 rw,errors=remount-ro 0 1
>> | > /var/archive/home /home none rw,bind 0 0
>> | > /var/archive/spool /var/spool none rw,bind 0 0
>> | > /var/archive/www /var/lib/www none rw,bind 0 0
>>
>> | Is this mtab really a link to /proc/mounts?
>>
>> No, its a standalone file.
>>
>> | That's the normal case on modern Linux distros.
>>
>> Its not a modern linux. :-)
>>
>> | > $ df-8.22 -h
>> | > Filesystem Size Used Avail Use% Mounted on
>> | > /dev/md0 21G 8.8G 11G 46% /
>> | > tmpfs 4.0K 0 4.0K 0% /dev
>> | >
>> | > And where is /dev/md1 ?
>>
>> | Not sure what's going on here.
>> | Since you've compiled various versions,
>> | could you replace src/df.c in your 8.22 build dir with:
>> |
>> http://git.sv.gnu.org/gitweb/?p=coreutils.git;a=blob_plain;f=src/df.c;hb=HEAD
>> | There have been many df changes since 8.22, so it would
>> | be good to check with the latest.
>>
>> $ /tmp/df-git -h
>> Filesystem Size Used Avail Use% Mounted on
>> /dev/md0 21G 9.0G 11G 47% /
>> tmpfs 4.0K 0 4.0K 0% /dev
>>
>> Same problem, /dev/md1 missing.
>
> The missing entry is due to the bind mounts being classified as "dummy"
> devices.
> There is code in gnulib to explicitly avoid that for bind mounts,
> however that was negated with this change:
> http://git.sv.gnu.org/gitweb/?p=gnulib.git;a=commitdiff;h=62bb7a8b
> Now that change is correct in isolation, but when combined
> with the incomplete original change, it triggered the issue.
> The attached patch should fix this up.
Actually this was the cause of another bug wrt bind mounts in du.
Andrew had identified the issue independently, so I'm applying this
in this name now and marking http://bugs.gnu.org/16189 as done
thanks,
Pádraig.
--- End Message ---