[debbugs-tracker] bug#16394: closed ([PATCH] Custom option to turn Flyspell mode on in prog modes)

[GNU bug Tracking System]

Your message dated Fri, 08 Aug 2014 16:10:39 +0200
with message-id <address@hidden>
and subject line Re: bug#16394: [PATCH] Custom option to turn Flyspell mode on 
in prog modes
has caused the debbugs.gnu.org bug report #16394,
regarding [PATCH] Custom option to turn Flyspell mode on in prog modes
to be marked as done.

(If you believe you have received this mail in error, please contact
address@hidden)


-- 
16394: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=16394
GNU Bug Tracking System
Contact address@hidden with problems
> --- Begin Message ---
>
>
>
> Subject: 
>
> Re: [PATCH] Custom option to turn Flyspell mode on in prog modes
>
>
>
>
> Date: 
>
> Thu, 12 Dec 2013 00:17:25 +0100
>
>
>
>
> User-agent: 
>
> Gnus (www.gnus.org), GNU Emacs (www.gnu.org/software/emacs/)
>
>
>
>
> Package: emacs
> Tags: patch
> Severity: wishlist
> Version: 24.3
>
> [ resent from
>  http://lists.gnu.org/archive/html/emacs-devel/2013-12/msg00353.html ]
>
> > Looks good.  But I don't think `turn-on-flyspell-prog' is needed 
> > because  `flyspell-prog-mode' already turns the mode on 
> > unconditionally.  (Although  maybe the latter should be 
> > reconsidered.) 
>
> You are right. The following works well.
>
> >From 29893db295fa1d01f9eec0f3f029b33d9a523a49 Mon Sep 17 00:00:00 2001
> From: Matthias Meulien <address@hidden>
> Date: Thu, 12 Dec 2013 00:09:16 +0100
> Subject: [PATCH] lisp/progmodes/prog-mode.el: Add custom options to mode hook
>
> ---
>  lisp/progmodes/prog-mode.el | 6 ++++++
>  1 file changed, 6 insertions(+)
>
> diff --git a/lisp/progmodes/prog-mode.el b/lisp/progmodes/prog-mode.el
> index b3ed328..f325a67 100644
> --- a/lisp/progmodes/prog-mode.el
> +++ b/lisp/progmodes/prog-mode.el
> @@ -35,6 +35,12 @@
>    "Generic programming mode, from which others derive."
>    :group 'languages)
>  
> +(defcustom prog-mode-hook nil
> +  "Normal hook run when entering Text mode and many related modes."
> +  :type 'hook
> +  :options '(flyspell-prog-mode abbrev-mode flymake-mode linum-mode)
> +  :group 'prog-mode)
> +
>  (defvar prog-mode-map
>    (let ((map (make-sparse-keymap)))
>      (define-key map [?\C-\M-q] 'prog-indent-sexp)
> -- 
> 1.8.5.1
>
> -- 
> Matthias
>
> --- End Message ---
> --- Begin Message ---
>
>
>
> Subject: 
>
> Re: bug#16394: [PATCH] Custom option to turn Flyspell mode on in prog modes
>
>
>
>
> Date: 
>
> Fri, 08 Aug 2014 16:10:39 +0200
>
>
>
>
> User-agent: 
>
> KMail/4.13.2 (Linux/3.13.0-30-generic; KDE/4.13.2; x86_64; ; )
>
>
>
>
> close 16394 r117667
>
> Applied in r117667 (ChangeLog fix in r117668).
>
> On Thursday 12 December 2013 00:17:25 Matthias Meulien wrote:
> > Package: emacs
> > Tags: patch
> > Severity: wishlist
> > Version: 24.3
> > 
> > [ resent from
> >   http://lists.gnu.org/archive/html/emacs-devel/2013-12/msg00353.html ]
> > 
> > > Looks good.  But I don't think `turn-on-flyspell-prog' is needed
> > > because  `flyspell-prog-mode' already turns the mode on
> > > unconditionally.  (Although  maybe the latter should be
> > > reconsidered.)
> > 
> > You are right. The following works well.
>
>
>
> --- End Message ---