[debbugs-tracker] bug#18825: closed (eww does not handle file:/file/name properly )

[GNU bug Tracking System]

Your message dated Sun, 02 Nov 2014 16:08:24 -0500
with message-id <address@hidden>
and subject line Re: bug#18825: eww does not handle file:/file/name properly
has caused the debbugs.gnu.org bug report #18825,
regarding eww does not handle file:/file/name properly 
to be marked as done.

(If you believe you have received this mail in error, please contact
address@hidden)


-- 
18825: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=18825
GNU Bug Tracking System
Contact address@hidden with problems
> --- Begin Message ---
>
>
>
> Subject: 
>
> eww does not handle file:/file/name properly 
>
>
>
>
> Date: 
>
> Sat, 25 Oct 2014 12:17:50 +0000
>
>
>
>
> User-agent: 
>
> Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux)
>
>
>
>
> Package:  emacs
> Severity: minor
> Tags:     patch
>
>         The condition currently employed in ‘eww’ for file: scheme URIs
>         is a bit more restrictive than necessary:
>
>    156  ;;;###autoload
>    157  (defun eww (url)
>    158    "Fetch URL and render the page.
>    159  If the input doesn't look like an URL or a domain name, the
>    160  word(s) will be searched for via `eww-search-prefix'."
>    161    (interactive "sEnter URL or keywords: ")
>    162    (cond ((string-match-p "\\`file://" url))
>    163          ((string-match-p "\\`ftp://"; url)
>    164           (user-error "FTP is not supported."))
>
>         While RFC 1738 does not allow for no-authority file: URIs,
>         RFC 3986 makes the authority part optional /in general,/ and
>         recognizing file:/name as synonymous to file:///name looks like
>         a common extension over the RFC 1738 syntax.
>
>         I thus suggest the condition to be relaxed to only include a
>         single slash after ‘file:’.
>
> -- 
> FSF associate member #7257  http://boycottsystemd.org/  … 3013 B6A0 230E 334A
>
> --- eww.el
> +++ eww.el
> @@ -159,7 +159,7 @@ eww (url)
>  If the input doesn't look like an URL or a domain name, the
>  word(s) will be searched for via `eww-search-prefix'."
>    (interactive "sEnter URL or keywords: ")
> -  (cond ((string-match-p "\\`file://" url))
> +  (cond ((string-match-p "\\`file:/" url))
>          ((string-match-p "\\`ftp://"; url)
>           (user-error "FTP is not supported."))
>          (t
>
> --- End Message ---
> --- Begin Message ---
>
>
>
> Subject: 
>
> Re: bug#18825: eww does not handle file:/file/name properly
>
>
>
>
> Date: 
>
> Sun, 02 Nov 2014 16:08:24 -0500
>
>
>
>
> User-agent: 
>
> Gnus/5.130012 (Ma Gnus v0.12) Emacs/25.0.50 (gnu/linux)
>
>
>
>
> On Sat, 25 Oct 2014 12:17:50 +0000 Ivan Shmakov <address@hidden> wrote: 
>
> IS> -  (cond ((string-match-p "\\`file://" url))
> IS> +  (cond ((string-match-p "\\`file:/" url))
>
> Thanks for the patch; applied in your name.  Closing.
>
> Ted
>
>
> --- End Message ---