emacs-bug-tracker
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[debbugs-tracker] bug#18579: closed (24.3.93; vc-bzr-after-dir-status sh


From: GNU bug Tracking System
Subject: [debbugs-tracker] bug#18579: closed (24.3.93; vc-bzr-after-dir-status should not skip ignored files)
Date: Mon, 24 Nov 2014 02:20:02 +0000

Your message dated Mon, 24 Nov 2014 04:19:13 +0200
with message-id <address@hidden>
and subject line Re: bug#18579: 24.3.93; vc-bzr-after-dir-status should not 
skip ignored files
has caused the debbugs.gnu.org bug report #18579,
regarding 24.3.93; vc-bzr-after-dir-status should not skip ignored files
to be marked as done.

(If you believe you have received this mail in error, please contact
address@hidden)


-- 
18579: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=18579
GNU Bug Tracking System
Contact address@hidden with problems
--- Begin Message --- Subject: 24.3.93; vc-bzr-after-dir-status should not skip ignored files Date: Mon, 29 Sep 2014 02:17:55 +0400
Tags: patch

Description of `dir-status-files' in vc.el says that this command's
output should include ignored files. vc-git implementation does, vc-bzr
implementation doesn't.

This is a problem in the context of the current feature request for
diff-hl to highlight ignored files in Dired buffers:

https://github.com/dgutov/diff-hl/issues/25

The trivial patch at the bottom seems to work okay.

In GNU Emacs 24.3.93.4 (x86_64-unknown-linux-gnu, GTK+ Version 3.10.8)
 of 2014-09-19 on axl
Repository revision: 117510 address@hidden
Windowing system distributor `The X.Org Foundation', version 11.0.11501000
System Description:     Ubuntu 14.04.1 LTS


=== modified file 'lisp/vc/vc-bzr.el'
--- lisp/vc/vc-bzr.el   2014-02-10 01:34:22 +0000
+++ lisp/vc/vc-bzr.el   2014-09-28 22:10:02 +0000
@@ -983,7 +983,7 @@
               (push (list new-name 'edited
                           (vc-bzr-create-extra-fileinfo old-name)) result)))
            ;; do nothing for non existent files
-           ((memq translated '(not-found ignored)))
+           ((memq translated '(not-found)))
            (t
             (push (list (file-relative-name
                          (buffer-substring-no-properties




--- End Message ---
--- Begin Message --- Subject: Re: bug#18579: 24.3.93; vc-bzr-after-dir-status should not skip ignored files Date: Mon, 24 Nov 2014 04:19:13 +0200 User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.2.0
Version: 24.5

On 09/30/2014 09:07 PM, Stefan Monnier wrote:

> You can install it into emacs-24 after we release 24.4, tho.

Done, as well as a patch for vc-hg with similar effect.

'hg status' can also list up-to-date files, but that makes the command take noticeably more time in larger repositories (1.2s vs 0.7s in mozilla-central, on my machine), so I figure we can live without it for now.

If/when someone decides to work on returning up-to-date files across different backends, they should open a new bug.


--- End Message ---

reply via email to

[Prev in Thread] Current Thread [Next in Thread]