--- Begin Message ---
|
Subject: |
25.0.50; [patch] Change the argument names of function-put (currently: "ARG1 ARG2 ARG3") |
|
Date: |
Thu, 20 Nov 2014 12:33:01 +0100 |
|
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/25.0.50 (gnu/linux) |
Hello,
>From -Q,
C-h f function-put RET gives:
> (function-put ARG1 ARG2 ARG3)
> Set function F's property PROP to VALUE.
> The namespace for PROP is shared with symbols.
> So far, F can only be a symbol, not a lambda expression.
I have the following patch -- is it ok to apply ?
>From 189ed20be419f0fb7edf0fd103e9df1d408136b9 Mon Sep 17 00:00:00 2001
From: Nicolas Richard <address@hidden>
Date: Thu, 20 Nov 2014 12:09:30 +0100
Subject: [PATCH] byte-run.el (function-put): Match argument names to
docstring.
---
lisp/ChangeLog | 5 +++++
lisp/emacs-lisp/byte-run.el | 8 +++++---
2 files changed, 10 insertions(+), 3 deletions(-)
diff --git a/lisp/ChangeLog b/lisp/ChangeLog
index 6fa23de..ba0ca35 100644
--- a/lisp/ChangeLog
+++ b/lisp/ChangeLog
@@ -1,3 +1,8 @@
+2014-11-20 Nicolas Richard <address@hidden>
+
+ * emacs-lisp/byte-run.el (function-put): Match argument names to
+ docstring.
+
2014-11-19 Lars Magne Ingebrigtsen <address@hidden>
* net/eww.el (eww-render): Remove a no-op :title setting.
diff --git a/lisp/emacs-lisp/byte-run.el b/lisp/emacs-lisp/byte-run.el
index 1f8b04e..4481f00 100644
--- a/lisp/emacs-lisp/byte-run.el
+++ b/lisp/emacs-lisp/byte-run.el
@@ -34,10 +34,12 @@
;; We don't want people to just use `put' because we can't conveniently
;; hook into `put' to remap old properties to new ones. But for now, there's
;; no such remapping, so we just call `put'.
- #'(lambda (f prop value) (put f prop value))
- "Set function F's property PROP to VALUE.
+ #'(lambda (function prop value) (put function prop value))
+ "Set function FUNCTION's property PROP to VALUE.
The namespace for PROP is shared with symbols.
-So far, F can only be a symbol, not a lambda expression.")
+So far, FUNCTION can only be a symbol, not a lambda expression.
+
+\(fn FUNCTION PROP VALUE)")
(function-put 'defmacro 'doc-string-elt 3)
(function-put 'defmacro 'lisp-indent-function 2)
--
2.0.4
--
Nicolas Richard
--- End Message ---
--- Begin Message ---
|
Subject: |
Re: bug#19118: 25.0.50; [patch] Change the argument names of function-put (currently: "ARG1 ARG2 ARG3") |
|
Date: |
Tue, 25 Nov 2014 13:57:15 +0100 |
|
User-agent: |
Mozilla/5.0 (X11; Linux i686; rv:31.0) Gecko/20100101 Thunderbird/31.2.0 |
Le 21/11/2014 03:56, Stefan Monnier a écrit :>> +
>> +\(fn FUNCTION PROP VALUE)")
>
> I think that the better way to get the right args, is to use a normal
> docstring, as in the patch below. I can't remember why I used
> a "defalias docstring" instead.
Ok, I pushed
commit 8be099a2c10ce4718e6630cef6b6ca1983617264
Author: Nicolas Richard <address@hidden>
Date: Thu Nov 20 12:09:30 2014 +0100
byte-run.el (function-put): Match argument names to docstring (bug#19118).
to master. Closing the bug (and crossing my fingers I did not mess up anything).
--
Nico.
--- End Message ---