--- Begin Message ---
Subject: |
[PATCH] OS/2 patches |
Date: |
Sun, 14 Dec 2014 12:47:37 +0900 |
Hi/2.
These are OS/2 patches for coreutils.
Review, please...
[PATCH 1/4] doc: add $(EXEEXT) suffix to the executables
[PATCH 2/4] build: configure.ac: support a response file on OS/2
[PATCH 3/4] cat,chcon,chgrp,chmod,chown,cp,du,head: support wildcards
[PATCH 4/4] build: use -pi.bak instead of -pi
--- End Message ---
--- Begin Message ---
Subject: |
Re: bug#19377: bug#19378: [PATCH 3/4] cat, chcon, chgrp, chmod, chown, cp, du, head: support wildcards on OS/2 |
Date: |
Thu, 18 Dec 2014 07:24:47 -0800 |
On Mon, Dec 15, 2014 at 9:11 PM, KO Myung-Hun <address@hidden> wrote:
> Jim Meyering wrote:
>> On Mon, Dec 15, 2014 at 8:35 PM, KO Myung-Hun <address@hidden> wrote:
>>> Paul Eggert wrote:
>>>> KO Myung-Hun wrote:
>>>>> /* Redirection and wildcarding when done by the utility itself.
>>>>> Generally a noop, but used in particular for native VMS. */
>>>>> #ifndef initialize_main
>>>>> -# define initialize_main(ac, av)
>>>>> +# ifndef __OS2__
>>>>> +# define initialize_main(ac, av)
>>>>> +# else
>>>>
>>>> What happened to VMS? The comment doesn't seem to match the code, and
>>>
>>> I don't know of VMS. Do you mean to change comments for OS/2 ?
>>>
>>>> this suggests that the code should be moved to wherever VMS does its thing.
>>>
>>> Where is it ? I didn't find initialize_main() or others for VMS.
>>
>> It was never defined in any version-controlled file,
>> so please just update the comment, replacing VMS with OS/2.
>
> Ok. Fixed.
Thanks.
Pushed with minor grammar fixes in the commit log.
--- End Message ---