[debbugs-tracker] bug#19551: closed (25.0.50; No lighter shown for `text-scale-mode' when it should be `+0')

[GNU bug Tracking System]

Your message dated Fri, 09 Jan 2015 18:48:46 -0500
with message-id <address@hidden>
and subject line Re: bug#19551: 25.0.50; No lighter shown for `text-scale-mode' 
when it should be `+0'
has caused the debbugs.gnu.org bug report #19551,
regarding 25.0.50; No lighter shown for `text-scale-mode' when it should be `+0'
to be marked as done.

(If you believe you have received this mail in error, please contact
address@hidden)


-- 
19551: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=19551
GNU Bug Tracking System
Contact address@hidden with problems
> --- Begin Message ---
>
>
>
> Subject: 
>
> 25.0.50; No lighter shown for `text-scale-mode' when it should be `+0'
>
>
>
>
> Date: 
>
> Fri, 9 Jan 2015 14:18:53 -0800 (PST)
>
>
>
>
> I don't know how or why this happens, but when buffer text is zoomed out
> and back in, so that the resulting text scale is neutral (100%, zero
> increase/decrease), the mode-line lighter should say `+0', as specified
> in the code (`face-remap.el').  For some reason, the lighter just
> disappears, as if the value of `text-scale-mode-lighter' were nil.
>
> In GNU Emacs 25.0.50.1 (i686-pc-mingw32)
>  of 2014-10-20 on LEG570
> Bzr revision: 118168 address@hidden
> Windowing system distributor `Microsoft Corp.', version 6.1.7601
> Configured using:
>  `configure --enable-checking=yes,glyphs CPPFLAGS=-DGLYPH_DEBUG=1'
>
>
>
> --- End Message ---
> --- Begin Message ---
>
>
>
> Subject: 
>
> Re: bug#19551: 25.0.50; No lighter shown for `text-scale-mode' when it should be `+0'
>
>
>
>
> Date: 
>
> Fri, 09 Jan 2015 18:48:46 -0500
>
>
>
>
> User-agent: 
>
> Gnus/5.13 (Gnus v5.13) Emacs/25.0.50 (gnu/linux)
>
>
>
>
> tags 19551 notabug
> thanks
>
> It's a feature.
>
>
>         Stefan
>
>
> >>>>> "Drew" == Drew Adams <address@hidden> writes:
>
> >> > I don't know how or why this happens, but when buffer text is zoomed out
> >> > and back in, so that the resulting text scale is neutral (100%, zero
> >> > increase/decrease), the mode-line lighter should say `+0', as specified
> >> > in the code (`face-remap.el').  For some reason, the lighter just
> >> > disappears, as if the value of `text-scale-mode-lighter' were nil.
> >> 
> >> I don't think this is a bug.  If I understand the code correctly, the
> >> lighter disappears because the minor mode is turned off when the text
> >> scale is 0; see this line in `text-scale-increase':
> >> 
> >> (text-scale-mode (if (zerop text-scale-mode-amount) -1 1))
>
> > Ah, right you are.  I didn't notice that.  I should have guessed this.
>
> >> I also don't see anywhere in face-remap.el that specifies the lighter is
> >> "+0" when the text scale is 0 (the default value of
> >> `text-scale-mode-lighter' is "+0", but changes as soon as
> >> text-scale-mode is enabled).
>
> > It's done in `text-scale-mode':
> > (setq text-scale-mode-lighter
> >       (format (if (>= text-scale-mode-amount 0) "+%d" "%d")
> >               text-scale-mode-amount))
>
> > That sets `text-scale-mode-lighter' to "+0" when `text-scale-mode-amount' is 
> > 0.
>
> > I'm OK with the bug being closed.
>
>
>
>
> --- End Message ---