[debbugs-tracker] bug#19658: closed (unportable test(1) comparison operator)

[GNU bug Tracking System]

Your message dated Sat, 24 Jan 2015 19:03:47 -0800
with message-id <address@hidden>
and subject line Re: unportable test(1) comparison operator
has caused the debbugs.gnu.org bug report #19658,
regarding unportable test(1) comparison operator
to be marked as done.

(If you believe you have received this mail in error, please contact
address@hidden)


-- 
19658: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=19658
GNU Bug Tracking System
Contact address@hidden with problems

--- Begin Message --- Subject: unportable test(1) comparison operator Date: Fri, 23 Jan 2015 00:10:07 +0100

Hi!

In emacs git as of yesterday, test/indent/shell.sh contains the
unportable '==' comparison operator for test(1) -- only bash supports
that, not even GNU coreutils' test(1).

Please use '=' instead; see attached patch.

Thanks,
 Thomas

P.S.: I know it's not intended to be executed, but I'd like to avoid
having bad examples around :)

patch-af
Description: Text document

--- End Message ---

> --- Begin Message ---
>
>
>
> Subject: 
>
> Re: unportable test(1) comparison operator
>
>
>
>
> Date: 
>
> Sat, 24 Jan 2015 19:03:47 -0800
>
>
>
>
> User-agent: 
>
> Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.4.0
>
>
>
>
> Thanks I changed it to '[ $# -eq 0 ]', which is more portable yet, as it works 
> even if a purposely-pedantic shell sets $# to '00'.
>
>
> --- End Message ---