emacs-bug-tracker
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[debbugs-tracker] bug#20256: closed (25.0.50; css-mode: filling multi-li


From: GNU bug Tracking System
Subject: [debbugs-tracker] bug#20256: closed (25.0.50; css-mode: filling multi-line comments)
Date: Sat, 18 Apr 2015 18:34:02 +0000

Your message dated Sat, 18 Apr 2015 20:33:39 +0200
with message-id <address@hidden>
and subject line Re: bug#20256: 25.0.50; css-mode: filling multi-line comments
has caused the debbugs.gnu.org bug report #20256,
regarding 25.0.50; css-mode: filling multi-line comments
to be marked as done.

(If you believe you have received this mail in error, please contact
address@hidden)


-- 
20256: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=20256
GNU Bug Tracking System
Contact address@hidden with problems
--- Begin Message --- Subject: 25.0.50; css-mode: filling multi-line comments Date: Sat, 04 Apr 2015 15:12:31 +0200
Filling multi-line comments in `css-mode' is broken. Consider for
instance the following comment:

  /*
   * Multi-line comment here.
   * This comment spans
   * multiple
   * lines.
   * Better fill it!
   */

Filling it with a `fill-column' of 70, I'd expect the following
result:

  /*
   * Multi-line comment here.  This comment spans multiple lines.
   * Better fill it!
   */

But as of now, what we get is this:

  /* * Multi-line comment here.  * This comment spans * multiple *
  lines.  * Better fill it!  */

From this comment in `css-fill-paragraph', it sounds like it is
supposed to work, or has been working some time before:

  ;; Filling inside a comment whose comment-end marker is not \n.
  ;; This code is meant to be generic, so that it works not only for
  ;; css-mode but for all modes.

Could someone fill me in?

Alternatively, we could let `css-mode' borrow comment filling code
from `cc-mode', like `js-mode' and `js2-mode' do. Please let me know
if that would be an acceptable fix.

-- Simen

--- End Message ---
--- Begin Message --- Subject: Re: bug#20256: 25.0.50; css-mode: filling multi-line comments Date: Sat, 18 Apr 2015 20:33:39 +0200 On Sat, Apr 18, 2015 at 4:06 PM, Stefan Monnier <address@hidden> wrote:
Thank you. Looks good to me.

Installed.

Maybe we should even try to move this fill function to prog-mode.el.

Sounds good!

-- Simen

--- End Message ---

reply via email to

[Prev in Thread] Current Thread [Next in Thread]