--- Begin Message ---
|
Subject: |
checkdoc-current-buffer prints to stdout?! |
|
Date: |
Sat, 06 Jun 2015 11:50:57 -0700 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0 |
[The following bug report was sent by Sebastian Wiesner to emacs-devel
<http://lists.gnu.org/archive/html/emacs-devel/2015-06/msg00095.html>.]
Hello,
while debugging unit test failures in Flycheck, I accidentally discovered
checkdoc-current-buffer apparently prints messages to standard output in
Emacs 25.1 in noninteractive mode.
Would you please revert this change?
I can understand the motivation for this “feature”, but it's generally a
bad idea for an interactive function to print text to standard output
depending on an opaque global environment. It also makes backwards
compatibility harder than it needs to be: As things stand I have no choice
but to check the Emacs version to print Checkdoc Errors in a consistent way
across Emacs major versions, and that is somewhat ugly.
The purpose of this feature would also be served by a different entry
point—we have `ert-run-tests-interactively` and `ert-run-tests-batch`,
too. If that is impossible please at least expose an option to turn this
feature off.
On a related topic, I'd have fixed this issue much faster, had this change
been mentioned in the NEWS. Would you please be more strict about updating
NEWS for breaking changes such as this?
Sincerely,
Sebastian Wiesner
--- End Message ---
--- Begin Message ---
|
Subject: |
Re: bug#20754: checkdoc-current-buffer prints to stdout?! |
|
Date: |
Mon, 08 Jun 2015 11:33:00 +0200 |
|
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux) |
Sebastian Wiesner <address@hidden> writes:
> 2015-06-08 8:35 GMT+02:00 Oleh Krehel <address@hidden>:
>
> Sebastian Wiesner <address@hidden> writes:
>
> > Why can't you just leave checkdoc-current-buffer as is, and
> introduce
> > a new entry point?
>
> Done. Also added a NEWS entry.
>
>
> Thank you very much! That's a nice change which benefits Flycheck, and
> will make checkdoc easier as soon as Flycheck drops Emacs 24
> compatibility.
You're welcome, marking as done.
--- End Message ---