[debbugs-tracker] bug#21224: closed (guix system init --no-grub doesn't work)

[GNU bug Tracking System]

Your message dated Mon, 02 Nov 2015 23:54:23 +0100
with message-id <address@hidden>
and subject line Re: bug#21224: guix system init --no-grub doesn't work
has caused the debbugs.gnu.org bug report #21068,
regarding guix system init --no-grub doesn't work
to be marked as done.

(If you believe you have received this mail in error, please contact
address@hidden)


-- 
21068: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=21068
GNU Bug Tracking System
Contact address@hidden with problems
> --- Begin Message ---
>
>
>
> Subject: 
>
> guix system init --no-grub doesn't work
>
>
>
>
> Date: 
>
> Sun, 09 Aug 2015 13:17:30 -0400
>
>
>
>
> I'm in the early stages of adding GuixSD for the Lemote Yeeloong, and so
> for now would like to avoid getting grub working on the Yeeloong.  So,
> I tried running "guix system init config.scm /target --no-grub", and
> this is what happens:
>
>   /gnu/store/...-system
>
>   initializing operating system under '/target'...
>   guix system: error: build failed: path `/gnu/store/...-grub.cfg' is not valid
>
> In the 'install' procedure in (guix scripts system), I tried changing:
>
>   (maybe-copy grub.cfg)
>
> to:
>
>   (mwhen grub?
>     (maybe-copy grub.cfg))
>
> and then the command works, but almost nothing gets copied to /target.
> In retrospect, this makes sense: as the comment says, the installer
> works by copying the *closure* of grub.cfg.  However, it fails when
> --no-grub is passed, apparently because grub.cfg was not built.
>
>       Mark
>
>
>
> --- End Message ---
> --- Begin Message ---
>
>
>
> Subject: 
>
> Re: bug#21224: guix system init --no-grub doesn't work
>
>
>
>
> Date: 
>
> Mon, 02 Nov 2015 23:54:23 +0100
>
>
>
>
> User-agent: 
>
> Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux)
>
>
>
>
> Mark H Weaver <address@hidden> skribis:
>
> > I ran into the same problem while porting GuixSD to MIPS, before I had
> > GRUB working.
> >
> > The problem here is that the method for copying the necessary store
> > items to the target directory is to copy grub.cfg and its transitive
> > closure, using (maybe-copy grub.cfg).
> >
> > However, if --no-grub is specified, then grub.cfg is not built.
> >
> > The preliminary approach I used successfully was to build and install
> > grub.cfg even if --no-grub is specified, although 'grub-install' is not
> > run in that case.  Here's the patch I used:
> >
> > diff --git a/guix/scripts/system.scm b/guix/scripts/system.scm
> > index 45f5982..6ec1f29 100644
> > --- a/guix/scripts/system.scm
> > +++ b/guix/scripts/system.scm
> > @@ -331,8 +331,10 @@ boot directly to the kernel or to the bootloader."
> >                                               (if (eq? 'init action)
> >                                                   '()
> >                                                   (previous-grub-entries))))
> > -       (drvs   -> (if (and grub? (memq action '(init reconfigure)))
> > -                      (list sys grub grub.cfg)
> > +       (drvs   -> (if (memq action '(init reconfigure))
> > +                      (if grub?
> > +                          (list sys grub.cfg grub)
> > +                          (list sys grub.cfg))
> >                        (list sys)))
> >         (%         (maybe-build drvs #:dry-run? dry-run?
> >                                 #:use-substitutes? use-substitutes?)))
>
> Applied in a704361, thanks!
>
> Ludo’.
>
>
> --- End Message ---