[debbugs-tracker] bug#22353: closed (gnus-summary-refer-article problem when setting marks)

[GNU bug Tracking System]

Your message dated Fri, 22 Jan 2016 13:25:23 +0100
with message-id <address@hidden>
and subject line Fixed
has caused the debbugs.gnu.org bug report #22353,
regarding gnus-summary-refer-article problem when setting marks
to be marked as done.

(If you believe you have received this mail in error, please contact
address@hidden)


-- 
22353: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=22353
GNU Bug Tracking System
Contact address@hidden with problems

--- Begin Message --- Subject: gnus-summary-refer-article problem when setting marks Date: Tue, 12 Jan 2016 08:47:35 +0100 User-agent: Gnus/5.130014 (Ma Gnus v0.14) Emacs/24.5 (darwin)

Hello,

I think I found a bug with `gnus-summary-refer-article'. If I fetch an
article that comes from another group, it gets inserted in the summary
with a number of -1. During the call to `gnus-summary-mark-article', the
following is done

(setq mark (gnus-request-update-mark gnus-newsgroup-name article mark))

which results in mark being nil. This in turn makes the comparisons such
as

(= mark gnus-unread-mark)

fail with a "Wrong type argument: number-or-marker-p, nil".

Here is a trimmed-down backtrace:

Debugger entered--Lisp error: (wrong-type-argument number-or-marker-p nil)
  =(nil 32)
  ...
  gnus-summary-mark-article(-1 82)
  gnus-summary-mark-read-and-unread-as-read()
  run-hooks(gnus-mark-article-hook)
  apply(run-hooks gnus-mark-article-hook)
  gnus-run-hooks(gnus-mark-article-hook)
  gnus-article-prepare(-1 nil)
  gnus-summary-display-article(-1 nil)
  gnus-summary-select-article(nil nil nil -1)
  (progn (gnus-summary-select-article nil nil nil number) (throw (quote found) 
t))
  ...
  gnus-summary-refer-article("address@hidden")
  call-interactively(gnus-summary-refer-article nil nil)
  command-execute(gnus-summary-refer-article)




Ma Gnus v0.14
GNU Emacs 24.5.1 (x86_64-apple-darwin15.2.0, Carbon Version 157 AppKit 1404.34)
 of 2015-12-17 on charm-ecran.irisa.fr
200 news.gmane.org InterNetNews NNRP server INN 2.5.1 ready (posting ok)
100 Legal commands
  ARTICLE [message-ID|number]
  AUTHINFO USER name|PASS password|GENERIC program [argument ...]
  BODY [message-ID|number]
  CAPABILITIES [keyword]
  DATE
  GROUP newsgroup
  HDR header [message-ID|range]
  HEAD [message-ID|number]
  HELP
  IHAVE message-ID
  LAST
  LIST [ACTIVE [wildmat]|ACTIVE.TIMES 
[wildmat]|DISTRIB.PATS|DISTRIBUTIONS|HEADERS 
[MSGID|RANGE]|MODERATORS|MOTD|NEWSGROUPS [wildmat]|OVERVIEW.FMT|SUBSCRIPTIONS]
  LISTGROUP [newsgroup [range]]
  MODE READER
  NEWGROUPS [yy]yymmdd hhmmss [GMT]
  NEWNEWS wildmat [yy]yymmdd hhmmss [GMT]
  NEXT
  OVER [range]
  POST
  QUIT
  STARTTLS
  STAT [message-ID|number]
  XGTITLE [wildmat]
  XHDR header [message-ID|range]
  XOVER [range]
  XPAT header message-ID|range pattern [pattern ...]
Report problems to <address@hidden>.
.
382 Begin TLS negotiation now
100 Legal commands
  ARTICLE [message-ID|number]
  AUTHINFO USER name|PASS password|GENERIC program [argument ...]
  BODY [message-ID|number]
  CAPABILITIES [keyword]
  DATE
  GROUP newsgroup
  HDR header [message-ID|range]
  HEAD [message-ID|number]
  HELP
  IHAVE message-ID
  LAST
  LIST [ACTIVE [wildmat]|ACTIVE.TIMES 
[wildmat]|DISTRIB.PATS|DISTRIBUTIONS|HEADERS 
[MSGID|RANGE]|MODERATORS|MOTD|NEWSGROUPS [wildmat]|OVERVIEW.FMT|SUBSCRIPTIONS]
  LISTGROUP [newsgroup [range]]
  MODE READER
  NEWGROUPS [yy]yymmdd hhmmss [GMT]
  NEWNEWS wildmat [yy]yymmdd hhmmss [GMT]
  NEXT
  OVER [range]
  POST
  QUIT
  STARTTLS
  STAT [message-ID|number]
  XGTITLE [wildmat]
  XHDR header [message-ID|range]
  XOVER [range]
  XPAT header message-ID|range pattern [pattern ...]
Report problems to <address@hidden>.
.

-- 
OpenPGP Key ID : 040D0A3B4ED2E5C7
Athmospheric CO₂ (Updated January 10, 2016, Mauna Loa Obs.): 402.22 ppm

signature.asc
Description: PGP signature

--- End Message ---

--- Begin Message --- Subject: Fixed Date: Fri, 22 Jan 2016 13:25:23 +0100 User-agent: Gnus/5.130014 (Ma Gnus v0.14) Emacs/24.5 (darwin)

Hello,

This bug has been fixed in commit
41ae6ab8c74cb388999ed5411ac4c5823e1aa230 by having
`nnir-request-update-mark' defaulting to the original mark, instead of
nil.

Alan

-- 
OpenPGP Key ID : 040D0A3B4ED2E5C7
Athmospheric CO₂ (Updated January 20, 2016, Mauna Loa Obs.): 402.30 ppm

signature.asc
Description: PGP signature

--- End Message ---