emacs-bug-tracker
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[debbugs-tracker] bug#21799: closed (Requesting review for change to js.


From: GNU bug Tracking System
Subject: [debbugs-tracker] bug#21799: closed (Requesting review for change to js.el)
Date: Tue, 23 Feb 2016 10:15:02 +0000

Your message dated Tue, 23 Feb 2016 12:14:35 +0200
with message-id <address@hidden>
and subject line Re: bug#21799: Requesting review for change to js.el
has caused the debbugs.gnu.org bug report #21799,
regarding Requesting review for change to js.el
to be marked as done.

(If you believe you have received this mail in error, please contact
address@hidden)


-- 
21799: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=21799
GNU Bug Tracking System
Contact address@hidden with problems
--- Begin Message --- Subject: Requesting review for change to js.el Date: Sat, 31 Oct 2015 02:37:33 -0700
See attached patch. Adds JSX indentation support to js-mode.

Attachment: jsx.patch
Description: Text Data


--- End Message ---
--- Begin Message --- Subject: Re: bug#21799: Requesting review for change to js.el Date: Tue, 23 Feb 2016 12:14:35 +0200 User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:44.0) Gecko/20100101 Thunderbird/44.0
On 02/23/2016 07:15 AM, Lars Ingebrigtsen wrote:

Looks good to me, I think, but I think it should probably be separated
out into its own file: jsx-mode.el.

Sorry, we've already applied it and forgot to close the bug.

Calling it jsx-mode.el might be suboptimal due to the conflict: https://github.com/jsx/jsx-mode.el (and that one's for a different JSX).

Also, I can't find your name in the Emacs copyright assignment file.

It's there, as "Jackson Ray Hamilton".


--- End Message ---

reply via email to

[Prev in Thread] Current Thread [Next in Thread]