emacs-bug-tracker
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[debbugs-tracker] bug#17213: closed (24.3.50; ruby-mode: misindented con


From: GNU bug Tracking System
Subject: [debbugs-tracker] bug#17213: closed (24.3.50; ruby-mode: misindented continuation method calls inside parens)
Date: Sun, 13 Mar 2016 23:51:02 +0000

Your message dated Mon, 14 Mar 2016 01:50:21 +0200
with message-id <address@hidden>
and subject line Re: bug#17213: Acknowledgement (24.3.50; ruby-mode: 
misindented continuation method calls inside parens)
has caused the debbugs.gnu.org bug report #17213,
regarding 24.3.50; ruby-mode: misindented continuation method calls inside 
parens
to be marked as done.

(If you believe you have received this mail in error, please contact
address@hidden)


-- 
17213: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=17213
GNU Bug Tracking System
Contact address@hidden with problems
--- Begin Message --- Subject: 24.3.50; ruby-mode: misindented continuation method calls inside parens Date: Mon, 07 Apr 2014 05:45:27 +0300
Example:

abc(foo
     .bar,
    tee
     .qux)

The lines with dots should be indented one column more.

Same if I move either dot to the end of the previous line, but keep the
called methods where they are.

I can fix that for the second method call with the patch at the bottom,
but the first one is unaffected. Not sure what would be the best fix for
it.

On a related note, it's worrisome that indentation of the these two
similar pieces of code in fairly similar positions is governed by
different logic.


=== modified file 'lisp/progmodes/ruby-mode.el'
--- lisp/progmodes/ruby-mode.el 2014-03-27 08:21:15 +0000
+++ lisp/progmodes/ruby-mode.el 2014-04-04 03:28:12 +0000
@@ -658,7 +658,7 @@
     (`(:before . ".")
      (if (smie-rule-sibling-p)
          (and ruby-align-chained-calls 0)
-       ruby-indent-level))
+       (smie-rule-parent ruby-indent-level)))
     (`(:before . ,(or `"else" `"then" `"elsif" `"rescue" `"ensure"))
      (smie-rule-parent))
     (`(:before . "when")




--- End Message ---
--- Begin Message --- Subject: Re: bug#17213: Acknowledgement (24.3.50; ruby-mode: misindented continuation method calls inside parens) Date: Mon, 14 Mar 2016 01:50:21 +0200 User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.0
Pushed a workaround in 5b705bc97d3928e6550d271c415c54e00e020011 to emacs-25.


--- End Message ---

reply via email to

[Prev in Thread] Current Thread [Next in Thread]