[debbugs-tracker] bug#22991: closed (25.0.92: C-u C-s does not display "Regexp I-search:" in the echo area)

[GNU bug Tracking System]

Your message dated Mon, 14 Mar 2016 20:17:38 +0200
with message-id <address@hidden>
and subject line Re: bug#22991: 25.0.92: C-u C-s does not display "Regexp 
I-search:" in the echo area
has caused the debbugs.gnu.org bug report #22991,
regarding 25.0.92: C-u C-s does not display "Regexp I-search:" in the echo area
to be marked as done.

(If you believe you have received this mail in error, please contact
address@hidden)


-- 
22991: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=22991
GNU Bug Tracking System
Contact address@hidden with problems

--- Begin Message --- Subject: 25.0.92: C-u C-s does not display "Regexp I-search:" in the echo area Date: Fri, 11 Mar 2016 14:48:29 -0500

Tested in the latest emacs-25 build as of today.

emacs -Q

C-u C-s

The echo area will show "I-search:".

Earlier it used to show "Regexp I-search:" and that made it clear that we are doing regexp search.

This change happened after this revert: http://git.savannah.gnu.org/cgit/emacs.git/commit/?h=emacs-25&id=b417c5a3b35bf31e66a170529c5aeb34cb3318d0

So it looks like that isearch-message-prefix was bound to search-default-mode being non-nil.

I verified that "C-u C-s" shows "Regexp I-search:" fine in emacs 24.5. But that version did not have the search-default-mode.

I believe that the clarity of regexp isearch being on/off is missing, especially when C-u C-s DOES do regexp search and still displays "I-search: " in the echo.

If I set search-default-mode back to "#'character-fold-to-regexp", this issue is gone. So displaying of "Regexp I-search:" should be decoupled from the character-fold.el library. 

--
Kaushal Modi

--- End Message ---

> --- Begin Message ---
>
>
>
> Subject: 
>
> Re: bug#22991: 25.0.92: C-u C-s does not display "Regexp I-search:" in the echo area
>
>
>
>
> Date: 
>
> Mon, 14 Mar 2016 20:17:38 +0200
>
>
>
>
> > Date: Mon, 14 Mar 2016 13:29:24 -0300
> > From: Artur Malabarba <address@hidden>
> > Cc: address@hidden, Drew Adams <address@hidden>, 
> >       Michael Heerdegen <address@hidden>, Juri Linkov <address@hidden>, Eli 
> > Zaretskii <address@hidden>
> > 
> > I can't push for the time being, but I agree with the patch. 
> > 
> > Eli, if you agree with it too, could you push it? 
>
> Pushed.
>
>
> --- End Message ---