[debbugs-tracker] bug#23357: closed ([PATCH] Don't let `css--property-values' return duplicates)

[GNU bug Tracking System]

Your message dated Sun, 24 Apr 2016 20:04:24 +0200
with message-id <address@hidden>
and subject line Re: bug#23357: [PATCH] Don't let `css--property-values' return 
duplicates
has caused the debbugs.gnu.org bug report #23357,
regarding [PATCH] Don't let `css--property-values' return duplicates
to be marked as done.

(If you believe you have received this mail in error, please contact
address@hidden)


-- 
23357: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=23357
GNU Bug Tracking System
Contact address@hidden with problems

--- Begin Message --- Subject: [PATCH] Don't let `css--property-values' return duplicates Date: Sun, 24 Apr 2016 14:57:22 +0200

By a recent discussion on emacs-devel I was made aware that

completion-at-point functions are themselves responsible for removing

duplicate entries in their results.

The attached patch ensures that `css--property-values' doesn't return

duplicate values as it would otherwise do sometimes, along with a

regression test for it.

-- Simen

0001-Don-t-let-css-property-values-return-duplicates.patch
Description: Text Data

--- End Message ---

--- Begin Message --- Subject: Re: bug#23357: [PATCH] Don't let `css--property-values' return duplicates Date: Sun, 24 Apr 2016 20:04:24 +0200 On Sun, Apr 24, 2016 at 4:51 PM, Stefan Monnier <address@hidden> wrote:

No they're not. It's the UI code (the code that calls completion-at-point-function) which is responsible for the removal of duplicates.

Ah, after rereading the conversation I see that I misunderstood it the

first time.

This said, removal of duplicates within the completion table, like your patch does, is harmless, so this is not an objection against your patch.

OK, then I still find it sensible to tidy up duplicates here. Patch

installed!

-- Simen

--- End Message ---