emacs-bug-tracker
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[debbugs-tracker] bug#23144: closed (shrinking windows with gtk 3.20)


From: GNU bug Tracking System
Subject: [debbugs-tracker] bug#23144: closed (shrinking windows with gtk 3.20)
Date: Mon, 16 May 2016 17:12:02 +0000

Your message dated Mon, 16 May 2016 10:11:48 -0700
with message-id <address@hidden>
and subject line Re: shrinking windows with gtk 3.20
has caused the debbugs.gnu.org bug report #23144,
regarding shrinking windows with gtk 3.20
to be marked as done.

(If you believe you have received this mail in error, please contact
address@hidden)


-- 
23144: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=23144
GNU Bug Tracking System
Contact address@hidden with problems
--- Begin Message --- Subject: shrinking windows with gtk 3.20 Date: Mon, 28 Mar 2016 16:52:47 -0400
We've observed that after

https://git.gnome.org/browse/gtk+/commit/?id=67ab00e01ec06d7b05a82c3d80b235ac6c4abfd2

emacs windows shrink to a small height, after initially appearing with
the expected size. For that reason, I have reverted to commit in the
stable gtk 3.20 branch.

But after looking a bit closer, I find that what emacs does is really
unsupportable: It handles X events behind GTK+'s back, and upon seeing
a map notify, it calls xg_frame_resized with -1, -1 for width and
height, which makes it call gdk_window_get_geometry to obtain the
current size. But at that point (before GTK+ has handled the map
notify), the function still returns the initial values of 1, 1, which
then leads eventually to a call of gtk_window_resize() with the small
height that we're seeing the window shrink to.

Therefore, I will bring back the reverted change in GTK+ master.

Possible workarounds/fixes in the emacs code:

1) Recognize when gdk_window_get_geometry returns the initial size
(1,1) and silently return as if the window was unmapped.

2) Just drop the xg_frame_resized call on MapNotify. Omitting it
doesn't have any noticeable negative consequences.



--- End Message ---
--- Begin Message --- Subject: Re: shrinking windows with gtk 3.20 Date: Mon, 16 May 2016 10:11:48 -0700 User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.0
On 05/16/2016 08:53 AM, Eli Zaretskii wrote:
we could reject GTK+ 3.20.4 and later for Emacs 25.1 at configure
time.

On further investigation of the Gtk+ source, it appears that the Gtk+ change went in at release 3.20.3. Since it seems clear that Emacs has serious problems in 3.20.3 or later because of the call to xg_frame_resized, I installed the attached patch and am boldly closing the bug report. Quite possibly there is a better way to fix the bug but I hope this is good enough to get by.

Attachment: 0001-Avoid-shrinking-windows-with-Gtk-3.20.3.patch
Description: Source code patch


--- End Message ---

reply via email to

[Prev in Thread] Current Thread [Next in Thread]