[debbugs-tracker] bug#23601: closed ([bisected] Emacs can't build after 2dc0ef29425b7)

[GNU bug Tracking System]

Your message dated Mon, 23 May 2016 17:56:25 +0200
with message-id <address@hidden>
and subject line Re: bug#23601: [bisected] Emacs can't build after 2dc0ef29425b7
has caused the debbugs.gnu.org bug report #23601,
regarding [bisected] Emacs can't build after 2dc0ef29425b7
to be marked as done.

(If you believe you have received this mail in error, please contact
address@hidden)


-- 
23601: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=23601
GNU Bug Tracking System
Contact address@hidden with problems

--- Begin Message --- Subject: [bisected] Emacs can't build after 2dc0ef29425b7 Date: Mon, 23 May 2016 11:19:48 +0800

Hi All,
Yesterday my emacs failed to build.
Here is the error msg:
`````
(require seq) while preparing to dump
Makefile:545: recipe for target 'emacs' failed
make[1]: *** [emacs] Error 255
make[1]: Leaving directory '/home/madper/source/emacs/src'
Makefile:398: recipe for target 'src' failed
make: *** [src] Error 2
`````

After bisect I got:
`````
λ  emacs  848d487 ✓ git bisect good
2dc0ef29425b7ee4c6c13b832c2a11dfe26ebb35 is the first bad commit
commit 2dc0ef29425b7ee4c6c13b832c2a11dfe26ebb35
Author: Nicolas Petton <address@hidden>
Date:   Sun May 22 21:51:11 2016 +0200

    Add missing dependencies to seq.el
   
    * lisp/emacs-lisp/find-func.el:
    * lisp/ibuffer.el:
    * lisp/image.el: Require seq.

:040000 040000 e3ae0052facd3cd6728259f6536363c0d0c9d70b 2105b394fefa44da3475d72f61be0f4f393ad985 M      lisp
`````

Thanks a lot in advance,
Madper

--- End Message ---

--- Begin Message --- Subject: Re: bug#23601: [bisected] Emacs can't build after 2dc0ef29425b7 Date: Mon, 23 May 2016 17:56:25 +0200 User-agent: Notmuch/0.21 (http://notmuchmail.org) Emacs/25.0.93.2 (x86_64-unknown-linux-gnu)

Glenn Morris <address@hidden> writes:

> Nicolas Petton wrote:
>
>> I actually do not know why adding (require 'seq) to image.el makes the
>> build fail.
>
> Files which are preloaded (ie, in loadup.el) cannot require any files
> that are not themselves in loadup (because those required files would
> then be preloaded too). This is an explicit check for such a case.

Commit c6493c6 fixes the problem, I'm closing this ticket.

Nico

signature.asc
Description: PGP signature

--- End Message ---