--- Begin Message ---
|
Subject: |
25.0.95; Mode Line breakage in vc-git |
|
Date: |
Tue, 14 Jun 2016 12:16:19 +0100 |
I am seeing a recurrent problem with vc, on Emacs-25. I am running emacs
via cask, which is running a test set.
The error looks like this:
vc-call-backend(Git mode-line-string "/home/phillord/emacs/lentic/de
vc-mode-line("/home/phillord/emacs/lentic/dev-resources/chunk-commen
vc-refresh-state()
run-hooks(find-file-hook)
after-find-file(nil t)
find-file-noselect-1(#<buffer chunk-comment.clj> "~/emacs/lentic/dev
find-file-noselect("/home/phillord/emacs/lentic/dev-resources/chunk-
(setq this (find-file-noselect filename))
(set-buffer (setq this (find-file-noselect filename)))
(save-current-buffer (set-buffer (setq this (find-file-noselect file
Initially, I only saw it when using Emacs in my git commit-hook -- the
same "make" command in the shell caused no problems. However, it is
freely reproducible by launching with "GIT_DIR=.git make -k" which
suggests this is why it is failing during the git commit.
I've tried "instrumenting" (i.e. putting lots of logging) into vc.
The immediate cause of the error appears to be in vc-git--call when it
runs the git command "symbolic-ref".
vc-git--call: about to apply: (git nil (t nil) nil symbolic-ref (HEAD))
vc-git--call: return 128
If GIT_DIR is not set this has a zero return value.
I haven't worked out yet, how to find what the error is (128 is "any
other error").
--- End Message ---
--- Begin Message ---
|
Subject: |
Re: bug#23769: 25.0.95; Mode Line breakage in vc-git |
|
Date: |
Wed, 22 Jun 2016 02:06:53 +0300 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:47.0) Gecko/20100101 Thunderbird/47.0 |
On 06/21/2016 11:45 PM, Phillip Lord wrote:
It's "Phillip" actually, but "Phil" is easier.
Oh. Sorry, Phillip.
Could you please pull the latest changes from emacs-25, rebuild, and
check that applying the patch from
http://debbugs.gnu.org/cgi/bugreport.cgi?bug=23769#86 fixes this
problem?
Yes, this appears to work on the emacs-25 head.
Thanks. Installed, with Eli's blessing.
Are you going to add the test case that I sent in also? If not, I'll
just add it to master (I don't think it will merge cleanly, so this
might be the best solution anyway).
Yes, please go ahead with it on master.
--- End Message ---