[debbugs-tracker] bug#19172: closed ([PATCH 1/1] Remove unused funcs that cause a building error)

[GNU bug Tracking System]

Your message dated Wed, 22 Jun 2016 16:49:01 +0200
with message-id <address@hidden>
and subject line Re: bug#19172: [PATCH 1/1] Remove unused funcs that cause a 
building error
has caused the debbugs.gnu.org bug report #19172,
regarding [PATCH 1/1] Remove unused funcs that cause a building error
to be marked as done.

(If you believe you have received this mail in error, please contact
address@hidden)


-- 
19172: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=19172
GNU Bug Tracking System
Contact address@hidden with problems
> --- Begin Message ---
>
>
>
> Subject: 
>
> [PATCH 1/1] Remove unused funcs that cause a building error
>
>
>
>
> Date: 
>
> Tue, 25 Nov 2014 00:14:32 +0100
>
>
>
>
> Remove unused static inline functions str_upcase_l() and
> str_downcase_l() that cause the compilation error
> 'dereferencing pointer to incomplete type' when building
> for ARM using a buildroot-generated toolchain.
>
> Signed-off-by: Pedro Aguilar <address@hidden>
> ---
>  libguile/i18n.c | 20 --------------------
>  1 file changed, 20 deletions(-)
>
> diff --git a/libguile/i18n.c b/libguile/i18n.c
> index c6b9b84..32278bd 100644
> --- a/libguile/i18n.c
> +++ b/libguile/i18n.c
> @@ -851,26 +851,6 @@ str_downcase (register char *dst, register const char *src)
>    *dst = '\0';
>  }
>  
> -#ifdef USE_GNU_LOCALE_API
> -static inline void
> -str_upcase_l (register char *dst, register const char *src,
> -             scm_t_locale locale)
> -{
> -  for (; *src != '\0'; src++, dst++)
> -    *dst = toupper_l (*src, locale);
> -  *dst = '\0';
> -}
> -
> -static inline void
> -str_downcase_l (register char *dst, register const char *src,
> -               scm_t_locale locale)
> -{
> -  for (; *src != '\0'; src++, dst++)
> -    *dst = tolower_l (*src, locale);
> -  *dst = '\0';
> -}
> -#endif
> -
>  
>  SCM_DEFINE (scm_string_locale_lt, "string-locale<?", 2, 1, 0,
>             (SCM s1, SCM s2, SCM locale),
> -- 
> 1.9.1
>
>
>
>
> --- End Message ---
> --- Begin Message ---
>
>
>
> Subject: 
>
> Re: bug#19172: [PATCH 1/1] Remove unused funcs that cause a building error
>
>
>
>
> Date: 
>
> Wed, 22 Jun 2016 16:49:01 +0200
>
>
>
>
> User-agent: 
>
> Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux)
>
>
>
>
> Thanks for the patch!  I applied a version that also deleted the
> previous two static inline helpers.  Weird to have them around.  Will be
> in 2.0.12 and 2.1.4.
>
> Cheers,
>
> Andy
>
> On Tue 25 Nov 2014 00:14, Pedro Aguilar <address@hidden> writes:
>
> > Remove unused static inline functions str_upcase_l() and
> > str_downcase_l() that cause the compilation error
> > 'dereferencing pointer to incomplete type' when building
> > for ARM using a buildroot-generated toolchain.
> >
> > Signed-off-by: Pedro Aguilar <address@hidden>
> > ---
> >  libguile/i18n.c | 20 --------------------
> >  1 file changed, 20 deletions(-)
> >
> > diff --git a/libguile/i18n.c b/libguile/i18n.c
> > index c6b9b84..32278bd 100644
> > --- a/libguile/i18n.c
> > +++ b/libguile/i18n.c
> > @@ -851,26 +851,6 @@ str_downcase (register char *dst, register const char 
> > *src)
> >    *dst = '\0';
> >  }
> >  
> > -#ifdef USE_GNU_LOCALE_API
> > -static inline void
> > -str_upcase_l (register char *dst, register const char *src,
> > -           scm_t_locale locale)
> > -{
> > -  for (; *src != '\0'; src++, dst++)
> > -    *dst = toupper_l (*src, locale);
> > -  *dst = '\0';
> > -}
> > -
> > -static inline void
> > -str_downcase_l (register char *dst, register const char *src,
> > -             scm_t_locale locale)
> > -{
> > -  for (; *src != '\0'; src++, dst++)
> > -    *dst = tolower_l (*src, locale);
> > -  *dst = '\0';
> > -}
> > -#endif
> > -
> >  
> >  SCM_DEFINE (scm_string_locale_lt, "string-locale<?", 2, 1, 0,
> >           (SCM s1, SCM s2, SCM locale),
>
>
> --- End Message ---