emacs-bug-tracker
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[debbugs-tracker] bug#24313: closed ([PATCH] Add tests for dom.el)


From: GNU bug Tracking System
Subject: [debbugs-tracker] bug#24313: closed ([PATCH] Add tests for dom.el)
Date: Sun, 28 Aug 2016 16:39:02 +0000

Your message dated Sun, 28 Aug 2016 18:38:00 +0200
with message-id <address@hidden>
and subject line Re: bug#24313: [PATCH] Add tests for dom.el
has caused the debbugs.gnu.org bug report #24313,
regarding [PATCH] Add tests for dom.el
to be marked as done.

(If you believe you have received this mail in error, please contact
address@hidden)


-- 
24313: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=24313
GNU Bug Tracking System
Contact address@hidden with problems
--- Begin Message --- Subject: [PATCH] Add tests for dom.el Date: Fri, 26 Aug 2016 20:26:10 +0200
Hello,

I saw that dom.el didn't have any tests, so I wrote some.

Do they look okay to add?

-- Simen

Attachment: 0001-Add-tests-for-dom.el.patch
Description: Text Data


--- End Message ---
--- Begin Message --- Subject: Re: bug#24313: [PATCH] Add tests for dom.el Date: Sun, 28 Aug 2016 18:38:00 +0200 On Sun, Aug 28, 2016 at 11:21 AM, Michael Albinus <address@hidden> wrote:
It depends. Likely you are right, but sometimes it might be worth to
note also what is NOT covered by a test, or to mention possible side
effects which are tested implicitely. But it is your decision, of course.

I agree with you. I went over the tests once more with this in mind and
found one instance which I think was worth a comment, but still think
the rest are trivial enough to stand on their own.

I've installed the tests with the changes you suggested last time.

Thanks again for your time.

-- Simen



--- End Message ---

reply via email to

[Prev in Thread] Current Thread [Next in Thread]