[debbugs-tracker] bug#24935: closed ([PATCH] Add tests for rot13.el)

[GNU bug Tracking System]

Your message dated Thu, 17 Nov 2016 19:23:17 +0100
with message-id <address@hidden>
and subject line Re: bug#24935: [PATCH] Add tests for rot13.el
has caused the debbugs.gnu.org bug report #24935,
regarding [PATCH] Add tests for rot13.el
to be marked as done.

(If you believe you have received this mail in error, please contact
address@hidden)


-- 
24935: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=24935
GNU Bug Tracking System
Contact address@hidden with problems

--- Begin Message --- Subject: [PATCH] Add tests for rot13.el Date: Sun, 13 Nov 2016 12:07:36 +0100

Hello,

I saw that there weren't any tests for rot13.el yet, so I wrote
some. I also made a docstring correction along the way.

Unless there are any objections, I'll install the patch within a few
days.

I also plan to turn on lexical binding for rot13.el in a follow-up
commit.

-- Simen

0001-Add-tests-for-rot13.el.patch
Description: Text Data

--- End Message ---

> --- Begin Message ---
>
>
>
> Subject: 
>
> Re: bug#24935: [PATCH] Add tests for rot13.el
>
>
>
>
> Date: 
>
> Thu, 17 Nov 2016 19:23:17 +0100
>
>
>
>
> Sounds good to me, thanks.
>
> Installed with your suggested change.
>
> -- Simen
>
> On Tue, Nov 15, 2016 at 9:23 PM, Eli Zaretskii <address@hidden> wrote:
> > >  Date: Tue, 15 Nov 2016 19:43:55 +0100
> > >  From: Simen Heggestøyl <address@hidden>
> > >  Cc: address@hidden
> > >
> > >    "ROT13 encrypt OBJECT, a buffer or string.
> > >  Return the ROT13 encrypted string when OBJECT is a string,
> > >  ignoring START and END.  ROT13 encrypt the region between
> > >  positions START and END when OBJECT is a buffer; all three
> > >  arguments are then required."
> >
> > It sounds strange to describe first the use case where the arguments
> > are ignored.  I suggest this instead:
> >
> >   ROT13 encrypt OBJECT, a buffer or string.
> > If OBJECT is a buffer, encrypt the region between START and END.
> > If OBJECT is a string, encrypt it in its entirety, ignoring START
> > and END, and return the encrypted string.
>
>
>
> --- End Message ---