[debbugs-tracker] bug#25128: closed (Reorder lisp.h to declare types before using them)

[GNU bug Tracking System]

Your message dated Sun, 25 Dec 2016 09:38:14 -0800
with message-id <address@hidden>
and subject line Re: bug#25128: Reorder lisp.h to declare types before using 
them
has caused the debbugs.gnu.org bug report #25128,
regarding Reorder lisp.h to declare types before using them
to be marked as done.

(If you believe you have received this mail in error, please contact
address@hidden)


-- 
25128: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=25128
GNU Bug Tracking System
Contact address@hidden with problems

--- Begin Message --- Subject: Reorder lisp.h to declare types before using them Date: Tue, 6 Dec 2016 23:19:19 -0800 User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.5.1

Tags: patch

Attached is a patch to reorder src/lisp.h so that more types are declared before use. The main motivation is to eventually add support for -fcheck-pointer-bounds; future changes will need access to type sizes (e.g., XCONS might need sizeof (struct Lisp_Cons)), which should be easy after this change. Also, the change shortens lisp.h a bit and (if you ask me) makes it easier to read, since the basic functions for a type are now declared next to the type.

I would like to install this soon, and am posting this as a bug report to give Eli and others a heads-up, in case some MS-Windows module now needs to include process.h. This may be needed because XPROCESS is now defined in process.h instead of lisp.h; similarly for buffer.h, window.h, termhooks.h.

0001-Reorder-lisp.h-to-declare-types-before-using-them.patch
Description: Text Data

--- End Message ---

> --- Begin Message ---
>
>
>
> Subject: 
>
> Re: bug#25128: Reorder lisp.h to declare types before using them
>
>
>
>
> Date: 
>
> Sun, 25 Dec 2016 09:38:14 -0800
>
>
>
>
> User-agent: 
>
> Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.5.1
>
>
>
>
> I installed this patch, after fixing it up to work with the concurrency branch.
>
>
> --- End Message ---