[debbugs-tracker] bug#25923: closed (pkgsrc patches: improve mkostemp support)

[GNU bug Tracking System]

Your message dated Tue, 14 Mar 2017 12:32:02 +0100
with message-id <address@hidden>
and subject line Re: bug#25923: pkgsrc patches: improve mkostemp support
has caused the debbugs.gnu.org bug report #25923,
regarding pkgsrc patches: improve mkostemp support
to be marked as done.

(If you believe you have received this mail in error, please contact
address@hidden)


-- 
25923: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=25923
GNU Bug Tracking System
Contact address@hidden with problems

--- Begin Message --- Subject: pkgsrc patches: improve mkostemp support Date: Wed, 1 Mar 2017 21:29:26 +0100

And the final pkgsrc patch tries to use only the flags for mkostemp
that are supported on the operating system, in particular for Darwin
and NetBSD.

Please merge this one as well.

Thanks,
 Thomas

patch-libguile_filesys.c
Description: Text document

--- End Message ---

> --- Begin Message ---
>
>
>
> Subject: 
>
> Re: bug#25923: pkgsrc patches: improve mkostemp support
>
>
>
>
> Date: 
>
> Tue, 14 Mar 2017 12:32:02 +0100
>
>
>
>
> User-agent: 
>
> Gnus/5.13 (Gnus v5.13) Emacs/25.1 (gnu/linux)
>
>
>
>
> On Wed 01 Mar 2017 21:29, Thomas Klausner <address@hidden> writes:
>
> > --- libguile/filesys.c.orig   2016-12-15 00:03:33.000000000 +0000
> > +++ libguile/filesys.c
> > @@ -1486,6 +1486,15 @@ SCM_DEFINE (scm_i_mkstemp, "mkstemp!", 1
> >        mode_bits = scm_i_mode_bits (mode);
> >      }
> >  
> > +#ifdef __APPLE__
> > +  /* https://debbugs.gnu.org/cgi/bugreport.cgi?bug=24862#23 */
> > +  open_flags &= O_APPEND|O_SHLOCK|O_EXLOCK|O_CLOEXEC;
> > +#endif
> > +#ifdef __NetBSD__
> > +  /* Restrict to list of flags documented in man page. */
> > +  open_flags &= O_APPEND|O_DIRECT|O_SHLOCK|O_EXLOCK|O_SYNC|O_CLOEXEC;
> > +#endif
> > +
> >    SCM_SYSCALL (rv = mkostemp (c_tmpl, open_flags));
> >    if (rv == -1)
> >      SCM_SYSERROR;
>
> I believe this was fixed in 2.1.6 as well so you can drop this one too.
>
> Cheers,
>
> Andy
>
>
> --- End Message ---