[debbugs-tracker] bug#26717: closed (Avoid references to the store in authorized_keys)

[GNU bug Tracking System]

Your message dated Wed, 03 May 2017 21:47:26 +0200
with message-id <address@hidden>
and subject line Re: bug#26717: [PATCH] gnu: gitolite: Avoid references to the 
store in authorized_keys.
has caused the debbugs.gnu.org bug report #26717,
regarding Avoid references to the store in authorized_keys
to be marked as done.

(If you believe you have received this mail in error, please contact
address@hidden)


-- 
26717: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=26717
GNU Bug Tracking System
Contact address@hidden with problems
> --- Begin Message ---
>
>
>
> Subject: 
>
> Avoid references to the store in authorized_keys
>
>
>
>
> Date: 
>
> Sun, 30 Apr 2017 18:30:57 +0200
>
>
>
>
> User-agent: 
>
> mu4e 0.9.18; emacs 25.2.1
>
>
>
>
> Note that if gitolite is already installed, one has to remove the
> references from authorized_keys manually first, because otherwise the
> old (bugged) gitolite will be used instead of the one in the PATH, and
> authorized_keys will never be updated.
>
>
>
> --- End Message ---
> --- Begin Message ---
>
>
>
> Subject: 
>
> Re: bug#26717: [PATCH] gnu: gitolite: Avoid references to the store in authorized_keys.
>
>
>
>
> Date: 
>
> Wed, 03 May 2017 21:47:26 +0200
>
>
>
>
> User-agent: 
>
> mu4e 0.9.18; emacs 25.2.1
>
>
>
>
> ng0 <address@hidden> writes:
>
> > Clément Lassieur transcribed 1.3K bytes:
> >> * gnu/packages/version-control.scm (gitolite)[arguments]: Substitute
> >> '$glshell' with 'gitolite-shell' in ssh-authkeys.
> >> ---
> >>  gnu/packages/version-control.scm | 8 +++++++-
> >>  1 file changed, 7 insertions(+), 1 deletion(-)
> >> 
> >> diff --git a/gnu/packages/version-control.scm 
> >> b/gnu/packages/version-control.scm
> >> index e0770dc58..1cad0f285 100644
> >> --- a/gnu/packages/version-control.scm
> >> +++ b/gnu/packages/version-control.scm
> >> @@ -628,7 +628,13 @@ also walk each side of a merge and test those changes 
> >> individually.")
> >>                          ;; invokes Perl.
> >>                          (substitute* (find-files "." ".*")
> >>                            ((" perl -")
> >> -                           (string-append " " perl " -"))))))
> >> +                           (string-append " " perl " -")))
> >> +
> >> +                        ;; Avoid references to the store in authorized_keys.
> >> +                        ;; This works because gitolite-shell is in the PATH.
> >> +                        (substitute* 
> >> "src/triggers/post-compile/ssh-authkeys"
> >> +                          (("\\$glshell \\$user")
> >> +                           "gitolite-shell $user")))))
> >>                    (replace 'install
> >>                      (lambda* (#:key outputs #:allow-other-keys)
> >>                        (let* ((output (assoc-ref outputs "out"))
> >> -- 
> >> 2.12.2
> >> 
> >> 
> >> 
> >> 
> >
> > This looks good. I have yet to test it. Do you think we could fix the hook 
> > files of gitolite like this too?
>
> Thank you :)  I pushed it.
>
>
> --- End Message ---