--- Begin Message ---
|
Subject: |
[PATCH 0/3] Fix guix refresh errors. |
|
Date: |
Thu, 4 May 2017 12:04:41 +0200 |
Hi Guix,
This serie fixes problems I ran into when running
guix refresh.
Thanks,
Mathieu
Mathieu Othacehe (3):
gnu: python-termcolor: Fix uri.
import: cran: Robustify cran-package?.
import: pypi: Robustify latest-release.
gnu/packages/python.scm | 2 +-
gnu/packages/statistics.scm | 1 +
guix/import/cran.scm | 7 ++++++-
guix/import/pypi.scm | 21 ++++++++++++---------
4 files changed, 20 insertions(+), 11 deletions(-)
--
2.12.2
--- End Message ---
--- Begin Message ---
|
Subject: |
Re: bug#26772: [PATCH 2/3] import: cran: Robustify cran-package?. |
|
Date: |
Sat, 13 May 2017 12:44:57 +0200 |
|
User-agent: |
mu4e 0.9.18; emacs 25.2.1 |
Hi Ludo !
Thanks for the review.
> This can be written as:
>
> (and start end (substring url …))
Done.
>
>> @@ -415,6 +417,9 @@ dependencies."
>> (define (cran-package? package)
>> "Return true if PACKAGE is an R package from CRAN."
>> (and (string-prefix? "r-" (package-name package))
>> + ;; Check if the upstream name can be extracted from package uri.
>> + (package->upstream-name package)
>> + ;; Check if package uri(s) are prefixed by "mirror://cran".
>> (match (and=> (package-source package) origin-uri)
>> ((? string? uri)
>> (string-prefix? "mirror://cran" uri))
>
> OK!
>
> Do you think you could add this specific case (r-minimal) as a test case
> for ‘cran-package?’ in tests/cran.scm? That would be awesome.
>
> Otherwise LGTM, thanks!
Sure I pushed this patch with the change above and a new test in
tests/cran.scm :
--8<---------------cut here---------------start------------->8---
(test-equal "r-mininal is not a cran package"
#f
((@@ (guix import cran) cran-package?) r-minimal))
--8<---------------cut here---------------end--------------->8---
I also pushed the two other patches of the serie.
Mathieu
--- End Message ---